Re: RFR 8191516: OutputStream.write(byte[], int, int) could have fewer parameter bounds checks

2017-11-21 Thread Paul Sandoz
> On 21 Nov 2017, at 12:30, Brian Burkhalter > wrote: > > On Nov 21, 2017, at 9:21 AM, Brian Burkhalter > wrote: > >>> Looks good. How about updating the read method as well to use the bounds

Re: RFR 8191516: OutputStream.write(byte[], int, int) could have fewer parameter bounds checks

2017-11-21 Thread Brian Burkhalter
On Nov 21, 2017, at 9:21 AM, Brian Burkhalter wrote: >> Looks good. How about updating the read method as well to use the bounds >> check method? (the len == 0 check makes sense there)? > > Probably might as well expand it a little to see where else similar

Re: RFR 8191516: OutputStream.write(byte[], int, int) could have fewer parameter bounds checks

2017-11-21 Thread Brian Burkhalter
On Nov 21, 2017, at 9:16 AM, Paul Sandoz wrote: >> Both good points. Updated accordingly: >> http://cr.openjdk.java.net/~bpb/8191516/webrev.01/. >> > > Looks good. How about updating the read method as well to use the bounds > check method? (the len == 0 check makes

Re: RFR 8191516: OutputStream.write(byte[], int, int) could have fewer parameter bounds checks

2017-11-21 Thread Paul Sandoz
> On 21 Nov 2017, at 08:47, Brian Burkhalter > wrote: > > > On Nov 20, 2017, at 6:32 PM, Paul Sandoz > wrote: > >> See also Objects.checkFromIndexSize if you wanna use that instead. >> >> Also the if len

Re: RFR 8191516: OutputStream.write(byte[], int, int) could have fewer parameter bounds checks

2017-11-21 Thread Brian Burkhalter
On Nov 20, 2017, at 6:32 PM, Paul Sandoz wrote: > See also Objects.checkFromIndexSize if you wanna use that instead. > > Also the if len == 0 check is probably redundant, i doubt it makes any > difference given the condition needs to be checked before entering the

Re: RFR 8191516: OutputStream.write(byte[], int, int) could have fewer parameter bounds checks

2017-11-20 Thread Paul Sandoz
> On 20 Nov 2017, at 16:53, Brian Burkhalter > wrote: > > https://bugs.openjdk.java.net/browse/JDK-8191516 > http://cr.openjdk.java.net/~bpb/8191516/webrev.00/ > > Change OutputStream.write(byte[],int,int) to use the same three parameter > bounds checks used by

RFR 8191516: OutputStream.write(byte[], int, int) could have fewer parameter bounds checks

2017-11-20 Thread Brian Burkhalter
https://bugs.openjdk.java.net/browse/JDK-8191516 http://cr.openjdk.java.net/~bpb/8191516/webrev.00/ Change OutputStream.write(byte[],int,int) to use the same three parameter bounds checks used by InputStream.read(byte[],int,int) instead of the five checks currently used. This change is covered