Re: RFR 8198970: jnu_util.c compilation error on Solaris

> On Mar 2, 2018, at 10:36 PM, David Holmes wrote: > > On 3/03/2018 8:56 AM, Roger Riggs wrote: >> Please review a correction to the jni_util.c native code that does not >> compile on Solaris. >> Declarations must precede assignments. > > Wow! I didn't think Solaris Studio compiler was subject

Re: RFR 8198970: jnu_util.c compilation error on Solaris

On 3/03/2018 8:56 AM, Roger Riggs wrote: Please review a correction to the jni_util.c native code that does not compile on Solaris. Declarations must precede assignments. Wow! I didn't think Solaris Studio compiler was subject to such anachronisms! We must be compiling in a really old mode. I

Re: RFR 8198970: jnu_util.c compilation error on Solaris

Thanks, Mandy, Claes, On 3/2/2018 6:02 PM, mandy chung wrote: +1 Mandy On 3/2/18 2:56 PM, Roger Riggs wrote: Please review a correction to the jni_util.c native code that does not compile on Solaris. Declarations must precede assignments. Issue: 8198970 jnu_util.c compilation error on Solar

Re: RFR 8198970: jnu_util.c compilation error on Solaris

Looks ok to me. /Claes On 2018-03-02 23:56, Roger Riggs wrote: Please review a correction to the jni_util.c native code that does not compile on Solaris. Declarations must precede assignments. Issue: 8198970 jnu_util.c compilation error on Solaris

Re: RFR 8198970: jnu_util.c compilation error on Solaris

+1 Mandy On 3/2/18 2:56 PM, Roger Riggs wrote: Please review a correction to the jni_util.c native code that does not compile on Solaris. Declarations must precede assignments. Issue: 8198970 jnu_util.c compilation error on Solaris diff --

RFR 8198970: jnu_util.c compilation error on Solaris

Please review a correction to the jni_util.c native code that does not compile on Solaris. Declarations must precede assignments. Issue: 8198970 jnu_util.c compilation error on Solaris diff --git a/src/java.base/share/native/libjava/jni_util.