Re: RFR 8207750 : Native handle leak in java.io.WinNTFileSystem.list()

2018-07-19 Thread Bernd Eckenfels
, Juli 18, 2018 4:38 AM An: Ivan Gerasimov Cc: core-libs-dev Betreff: Re: RFR 8207750 : Native handle leak in java.io.WinNTFileSystem.list() Hi Ivan, This looks all right to me. Thanks, Brian On Jul 17, 2018, at 5:01 PM, Ivan Gerasimov wrote: > In the file WinNTFileSystem_m

Re: RFR 8207750 : Native handle leak in java.io.WinNTFileSystem.list()

2018-07-17 Thread Thomas Stüfe
Hi Ivan, looks good. Best Regards, Thomas On Wed, Jul 18, 2018 at 2:01 AM, Ivan Gerasimov wrote: > Hello! > > In the file WinNTFileSystem_md.c there is a potential leak of native handle > obtained from FindFirstFileW() in the unfortunate event of memory allocation > failure. > > Would you

Re: RFR 8207750 : Native handle leak in java.io.WinNTFileSystem.list()

2018-07-17 Thread vyom tewari
Hi Ivan, looks good to me, although i am not the official reviewer. Thanks, Vyom On Wednesday 18 July 2018 05:31 AM, Ivan Gerasimov wrote: Hello! In the file WinNTFileSystem_md.c there is a potential leak of native handle obtained from FindFirstFileW() in the unfortunate event of memory

Re: RFR 8207750 : Native handle leak in java.io.WinNTFileSystem.list()

2018-07-17 Thread Ivan Gerasimov
Thank you Brian for review! On 7/17/18 5:08 PM, Brian Burkhalter wrote: Hi Ivan, This looks all right to me. Thanks, Brian On Jul 17, 2018, at 5:01 PM, Ivan Gerasimov > wrote: In the file WinNTFileSystem_md.c there is a potential leak of native handle

Re: RFR 8207750 : Native handle leak in java.io.WinNTFileSystem.list()

2018-07-17 Thread Brian Burkhalter
Hi Ivan, This looks all right to me. Thanks, Brian On Jul 17, 2018, at 5:01 PM, Ivan Gerasimov wrote: > In the file WinNTFileSystem_md.c there is a potential leak of native handle > obtained from FindFirstFileW() in the unfortunate event of memory allocation > failure. > > Would you

RFR 8207750 : Native handle leak in java.io.WinNTFileSystem.list()

2018-07-17 Thread Ivan Gerasimov
Hello! In the file WinNTFileSystem_md.c there is a potential leak of native handle obtained from FindFirstFileW() in the unfortunate event of memory allocation failure. Would you please help review a simple fix? BUGURL: https://bugs.openjdk.java.net/browse/JDK-8207750 WEBREV: