Re: RFR 8214245 : (regex) Case insensitive matching doesn't work correctly for some character classes

Thank you Roger! Pushed. With kind regards, Ivan On 3/17/20 5:20 PM, Roger Riggs wrote: Hi Ivan, I see the CSR is approved. I'm fine with the change. Regards, Roger On 2/25/20 3:18 PM, Ivan Gerasimov wrote: Thank you Roger for reviewing CSR and the release note! On 2/11/20 12:49 PM,

Re: RFR 8214245 : (regex) Case insensitive matching doesn't work correctly for some character classes

Hi Ivan, I see the CSR is approved. I'm fine with the change. Regards, Roger On 2/25/20 3:18 PM, Ivan Gerasimov wrote: Thank you Roger for reviewing CSR and the release note! On 2/11/20 12:49 PM, Roger Riggs wrote: Hi Ivan, Will this have enough of a compatibility concern to warrant a

Re: RFR 8214245 : (regex) Case insensitive matching doesn't work correctly for some character classes

Thank you Roger for reviewing CSR and the release note! On 2/11/20 12:49 PM, Roger Riggs wrote: Hi Ivan, Will this have enough of a compatibility concern to warrant a CSR? It will change the behavor of these cases. In the RegExTest, the failures should print which case is failing. (Line

Re: RFR 8214245 : (regex) Case insensitive matching doesn't work correctly for some character classes

Hi Ivan, The CSR and release note look fine. Roger On 2/24/20 8:54 PM, Ivan Gerasimov wrote: Thank you Roger and Joe for the feedback! May I please ask you to review the CSR draft [1] and the Release Notes [2] for this issue: [1] https://bugs.openjdk.java.net/browse/JDK-8238984 [2]

Re: RFR 8214245 : (regex) Case insensitive matching doesn't work correctly for some character classes

Thank you Roger and Joe for the feedback! May I please ask you to review the CSR draft [1] and the Release Notes [2] for this issue: [1] https://bugs.openjdk.java.net/browse/JDK-8238984 [2] https://bugs.openjdk.java.net/browse/JDK-8239887 Thanks in advance! Ivan On 2/11/20 3:10 PM, Joe

Re: RFR 8214245 : (regex) Case insensitive matching doesn't work correctly for some character classes

Hello, Yes, I believe this change should have a CSR, and most likely a release note. Thanks, -Joe On 2/11/2020 12:49 PM, Roger Riggs wrote: Hi Ivan, Will this have enough of a compatibility concern to warrant a CSR? It will change the behavor of these cases. In the RegExTest, the

Re: RFR 8214245 : (regex) Case insensitive matching doesn't work correctly for some character classes

Hi Ivan, Will this have enough of a compatibility concern to warrant a CSR? It will change the behavor of these cases. In the RegExTest, the failures should print which case is failing. (Line 4961, 4990). Regards, Roger On 2/7/20 3:05 PM, Ivan Gerasimov wrote: Gentle ping. I had to

Re: RFR 8214245 : (regex) Case insensitive matching doesn't work correctly for some character classes

Gentle ping. I had to rebase the fix, as the code has diverged since the RFR was sent out 10 months ago. Also, the test was slightly modified to cover more cases. BUGURL: https://bugs.openjdk.java.net/browse/JDK-8214245 WEBREV: http://cr.openjdk.java.net/~igerasim/8214245/01/webrev/ Thanks