Re: RFR 8214794 : java.specification.version should be only the major version number

2018-12-04 Thread Magnus Ihse Bursie
Looks good to me, too. /Magnus > 4 dec. 2018 kl. 20:34 skrev Mandy Chung : > > The revised webrev looks okay. > > Mandy > >> On 12/4/18 11:32 AM, Roger Riggs wrote: >> Hi Mandy, Martin, >> >> The new test is unnecessary, the case is covered by >> java/lang/System/Versions test >> and uses

Re: RFR 8214794 : java.specification.version should be only the major version number

2018-12-04 Thread Martin Buchholz
> > LGTM

Re: RFR 8214794 : java.specification.version should be only the major version number

2018-12-04 Thread Erik Joelsson
Looks good. /Erik On 2018-12-04 11:32, Roger Riggs wrote: Hi Mandy, Martin, The new test is unnecessary, the case is covered by java/lang/System/Versions test and uses the stronger comparison for the version numbers. It would not detect the problem unless the version included more than

Re: RFR 8214794 : java.specification.version should be only the major version number

2018-12-04 Thread Roger Riggs
Hi Mandy, Martin, The new test is unnecessary, the case is covered by java/lang/System/Versions test and uses the stronger comparison for the version numbers. It would not detect the problem unless the version included more than the major version. Webrev:

Re: RFR 8214794 : java.specification.version should be only the major version number

2018-12-04 Thread Mandy Chung
The revised webrev looks okay. Mandy On 12/4/18 11:32 AM, Roger Riggs wrote: Hi Mandy, Martin, The new test is unnecessary, the case is covered by java/lang/System/Versions test and uses the stronger comparison for the version numbers. It would not detect the problem unless the version

Re: RFR 8214794 : java.specification.version should be only the major version number

2018-12-04 Thread Brian Burkhalter
Hi Roger, Looks fine. Brian > On Dec 4, 2018, at 8:23 AM, Roger Riggs wrote: > > Including build-dev for the change to GensrcMisc.gmk. > > thx. > > On 12/04/2018 11:16 AM, Roger Riggs wrote: >> Please review correctly setting the java.specification.version property >> with only the major

Re: RFR 8214794 : java.specification.version should be only the major version number

2018-12-04 Thread Mandy Chung
On 12/4/18 8:16 AM, Roger Riggs wrote: Please review correctly setting the java.specification.version property with only the major version number.  A test is added to ensure the java spec version agrees with the major version. The symptoms are that jtreg would fail with a full version

Re: RFR 8214794 : java.specification.version should be only the major version number

2018-12-04 Thread Martin Buchholz
> > I would make a stronger assertion, that Runtime.version().feature() > converted to a String is equal to specVersion, catching bogus specVersions > like "+011"

Re: RFR 8214794 : java.specification.version should be only the major version number

2018-12-04 Thread Roger Riggs
Including build-dev for the change to GensrcMisc.gmk. thx. On 12/04/2018 11:16 AM, Roger Riggs wrote: Please review correctly setting the java.specification.version property with only the major version number.  A test is added to ensure the java spec version agrees with the major version. The

RFR 8214794 : java.specification.version should be only the major version number

2018-12-04 Thread Roger Riggs
Please review correctly setting the java.specification.version property with only the major version number.  A test is added to ensure the java spec version agrees with the major version. The symptoms are that jtreg would fail with a full version number. Webrev: