Re: RFR 8237599 : Greedy matching against supplementary chars fails to respect the region

2020-03-25 Thread Ivan Gerasimov
Thank you Roger for review! On 3/25/20 6:56 AM, Roger Riggs wrote: Hi Ivan, Looks fine. Interesting edge case, would never be seen with 8 bit charsets. Thanks, Roger On 3/21/20 3:15 AM, Ivan Gerasimov wrote: Gentle ping. The webrev was rebased to accommodate recent changes in RegExTest.j

Re: RFR 8237599 : Greedy matching against supplementary chars fails to respect the region

2020-03-25 Thread Roger Riggs
Hi Ivan, Looks fine. Interesting edge case, would never be seen with 8 bit charsets. Thanks, Roger On 3/21/20 3:15 AM, Ivan Gerasimov wrote: Gentle ping. The webrev was rebased to accommodate recent changes in RegExTest.java. The fix is to handle an edge case situation, which is supposedly

Re: RFR 8237599 : Greedy matching against supplementary chars fails to respect the region

2020-03-21 Thread Ivan Gerasimov
Gentle ping. The webrev was rebased to accommodate recent changes in RegExTest.java. The fix is to handle an edge case situation, which is supposedly not too common. Nevertheless, I think, it is important to handle it correctly. Thanks in advance! Ivan On 1/22/20 8:23 PM, Ivan Gerasimov w

RFR 8237599 : Greedy matching against supplementary chars fails to respect the region

2020-01-22 Thread Ivan Gerasimov
Hello everyone! When the input of a j.u.regex.Matcher is restricted with .region() method, it can possibly cut off a half of a surrogate pair. It turns out that greedy matching implemented in the Pattern.CharPropertyGreedy class fails to recognize this edge case in two scenarios: 1) When i