Re: RFR 8239893: Windows handle Leak when starting processes using ProcessBuilder

Looks good. Thanks for the update. Naoto On 3/6/20 8:17 AM, Roger Riggs wrote: Hi Naoto, Updated webrev: http://cr.openjdk.java.net/~rriggs/webrev-handles-8239893-1/index.html I don't think getting handle count of your own process can ever fail. But in the abundance of caution, added a check

Re: RFR 8239893: Windows handle Leak when starting processes using ProcessBuilder

Hi Roger, Looks good! Brian > On Mar 6, 2020, at 8:16 AM, Roger Riggs wrote: > > Updated webrev: > http://cr.openjdk.java.net/~rriggs/webrev-handles-8239893-1/index.html > > > The threshold is a pretty loose target.

Re: RFR 8239893: Windows handle Leak when starting processes using ProcessBuilder

Hi Naoto, Updated webrev: http://cr.openjdk.java.net/~rriggs/webrev-handles-8239893-1/index.html I don't think getting handle count of your own process can ever fail. But in the abundance of caution, added a check and failure. Copyright updated. Thanks, Roger Corrected copyright On 3/5/20 4

Re: RFR 8239893: Windows handle Leak when starting processes using ProcessBuilder

Hi Brian, Updated webrev: http://cr.openjdk.java.net/~rriggs/webrev-handles-8239893-1/index.html The threshold is a pretty loose target. Given the original error that leaked a handle for every process started, it just needs to detect a growing number of handles in use.  But for the sake of acc

Re: RFR 8239893: Windows handle Leak when starting processes using ProcessBuilder

Hi Roger, In the test, the error value (-1) from the native code seems silently suppressed. Should it be caught/reported in the java side? nit: copyright year in ProcessImpl.java -> 2020. Naoto On 3/5/20 12:51 PM, Roger Riggs wrote: Please review a change to the Windows ProcessImpl to ensure

Re: RFR 8239893: Windows handle Leak when starting processes using ProcessBuilder

Hi Roger, > On Mar 5, 2020, at 12:51 PM, Roger Riggs wrote: > > Please review a change to the Windows ProcessImpl to ensure that the handles > created for the input and output streams of a process are closed when no > longer referenced. > > Unlike on Linux, there is no thread monitoring the pr

RFR 8239893: Windows handle Leak when starting processes using ProcessBuilder

Please review a change to the Windows ProcessImpl to ensure that the handles created for the input and output streams of a process are closed when no longer referenced. Unlike on Linux, there is no thread monitoring the process that can close the streams. The FileDescriptors are registered wit