Hi Daniel,
Re-reading the java.io.Serial javadoc, the annotation is only appropriate on
the methods and fields specified as being part of the Serializalble
mechanism.
For example, readObject, writeObject, readResolve, wroteReplace, and
readObjectNoData,
and fields serialPersistentFields and se
Hi Roger,
On 21/08/2020 17:52, Roger Riggs wrote:
The @serial javadoc tag is used on any serialization related field or
method.
Are there some missing? I expect javac would warn if they were missing.
Well I was wondering whether an @serial tag would be appropriate in
the documentation of thes
On 8/21/20 8:09 AM, Roger Riggs wrote:
Please review the addition of comments to classes and fields to resolve
javadoc "no comment" warnings in the java.lang and java.io packages.
The comments are derived from the existing behavior and context.
Webrev:
http://cr.openjdk.java.net/~rriggs/we
Thanks for the reviews.
The copyright dates are updated in the webrev:
http://cr.openjdk.java.net/~rriggs/webrev-nocomment-8251203-2/
The @serial javadoc tag is used on any serialization related field or
method.
Are there some missing? I expect javac would warn if they were missing.
Thank
Hi Roger,
Changes look good to me. One question, do we need to update the
copyright year for this change?
Naoto
On 8/21/20 8:09 AM, Roger Riggs wrote:
Please review the addition of comments to classes and fields to resolve
javadoc "no comment" warnings in the java.lang and java.io packages.
Hi Roger,
Looks good overall.
Friendly reminder to update the copyright in the files such as File.java,
UncheckedIOException.java, AbstractStringBuilder.java etc...
> On Aug 21, 2020, at 11:09 AM, Roger Riggs wrote:
>
> Please review the addition of comments to classes and fields to resolv
On 21/08/2020 16:09, Roger Riggs wrote:
Please review the addition of comments to classes and fields to resolve
javadoc "no comment" warnings in the java.lang and java.io packages.
The comments are derived from the existing behavior and context.
Looks good to me Roger.
I don't quite recall whe
Please review the addition of comments to classes and fields to resolve
javadoc "no comment" warnings in the java.lang and java.io packages.
The comments are derived from the existing behavior and context.
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-nocomment-8251203-1/
CSR:
https:/
