Re: RFR 9: 8003488 Add Process.getPid

2014-07-23 Thread Florian Weimer
On 05/22/2014 05:34 PM, David M. Lloyd wrote: I guess this is a little late, and minor, but the jstack tool uses the acronym nid for this purpose, which I believe is mapped to the same concept (on Linux it is anyway). I think either this terminology should be unified on the jstack side, or else

Re: RFR 9: 8003488 Add Process.getPid

2014-05-27 Thread Alan Bateman
On 22/05/2014 20:47, roger riggs wrote: Thanks for the feedback and recommendations; the webrev has been updated. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-getpid-8003488/ Alan, on the use of tasklist, I think a cleaner test can be written when the Java API to inspect other processes

Re: RFR 9: 8003488 Add Process.getPid

2014-05-22 Thread roger riggs
Hi, The webrev has been updated to more completely describe the pid: The native process id is an identification number that the operating system assigns to the process. Any other comments? Webrev: http://cr.openjdk.java.net/~rriggs/webrev-getpid-8003488/

Re: RFR 9: 8003488 Add Process.getPid

2014-05-22 Thread Paul Benedict
Looks good. Don't forget @since 1.9 in the javadoc Cheers, Paul On Thu, May 22, 2014 at 8:49 AM, roger riggs roger.ri...@oracle.com wrote: Hi, The webrev has been updated to more completely describe the pid: The native process id is an identification number that the operating system

Re: RFR 9: 8003488 Add Process.getPid

2014-05-22 Thread Ivan Gerasimov
Hi Roger! On 22.05.2014 17:49, roger riggs wrote: Hi, The webrev has been updated to more completely describe the pid: The native process id is an identification number that the operating system assigns to the process. Any other comments? I assume it compiles fine, but in

Re: RFR 9: 8003488 Add Process.getPid

2014-05-22 Thread Alan Bateman
On 22/05/2014 14:49, roger riggs wrote: Hi, The webrev has been updated to more completely describe the pid: The native process id is an identification number that the operating system assigns to the process. Any other comments? Webrev:

Re: RFR 9: 8003488 Add Process.getPid

2014-05-22 Thread David M. Lloyd
On 05/22/2014 08:49 AM, roger riggs wrote: Hi, The webrev has been updated to more completely describe the pid: The native process id is an identification number that the operating system assigns to the process. Any other comments? Webrev:

Re: RFR 9: 8003488 Add Process.getPid

2014-05-22 Thread Alan Bateman
On 22/05/2014 16:34, David M. Lloyd wrote: I guess this is a little late, and minor, but the jstack tool uses the acronym nid for this purpose, which I believe is mapped to the same concept (on Linux it is anyway). I think either this terminology should be unified on the jstack side, or

Re: RFR 9: 8003488 Add Process.getPid

2014-05-22 Thread roger riggs
Hi, jstack -help uses pid; where are looking? Roger On 5/22/2014 11:34 AM, David M. Lloyd wrote: On 05/22/2014 08:49 AM, roger riggs wrote: Hi, The webrev has been updated to more completely describe the pid: The native process id is an identification number that the operating system

Re: RFR 9: 8003488 Add Process.getPid

2014-05-22 Thread David M. Lloyd
On 05/22/2014 10:34 AM, David M. Lloyd wrote: On 05/22/2014 08:49 AM, roger riggs wrote: Hi, The webrev has been updated to more completely describe the pid: The native process id is an identification number that the operating system assigns to the process. Any other comments? Webrev:

Re: RFR 9: 8003488 Add Process.getPid

2014-05-22 Thread David M. Lloyd
On 05/22/2014 10:44 AM, Alan Bateman wrote: On 22/05/2014 16:34, David M. Lloyd wrote: I guess this is a little late, and minor, but the jstack tool uses the acronym nid for this purpose, which I believe is mapped to the same concept (on Linux it is anyway). I think either this terminology

Re: RFR 9: 8003488 Add Process.getPid

2014-05-22 Thread roger riggs
Hi, Thanks for the rationale. Using the natural terminology familiar to developers seems most useful. Mac, Windows, and Linux refer to these values a process id or pid as the handle for a Process; it appears in the tools like ps and tasklist. The javadoc can explain anything more specific or

Re: RFR 9: 8003488 Add Process.getPid

2014-05-22 Thread roger riggs
Thanks for the feedback and recommendations; the webrev has been updated. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-getpid-8003488/ Alan, on the use of tasklist, I think a cleaner test can be written when the Java API to inspect other processes is available. I did not find a

Re: RFR 9: 8003488 Add Process.getPid

2014-05-14 Thread roger riggs
Hi, For system local process identifiers, all of the systems I'm aware are 32 bit integers, printed and parsed in decimal for ease of use. I would describe the native pid as: The native process id is the identifier commonly used in the operating system APIs and commands to show the

RFR 9: 8003488 Add Process.getPid

2014-05-12 Thread roger riggs
Please review and comment on this long requested addition to provide the native process id of a spawned Process. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-getpid-8003488/ Issue: https://bugs.openjdk.java.net/browse/JDK-8003488 Thanks, Roger

Re: RFR 9: 8003488 Add Process.getPid

2014-05-12 Thread roger riggs
Hi Martin, Alan mentioned this case but it seemed more difficult to use than the primitive. For the other parts of JEP 102, I expect to represent a process with a type that can have additional methods. That type would provide stronger typing and a set of useful operations. It seems less

Re: RFR 9: 8003488 Add Process.getPid

2014-05-12 Thread Paul Benedict
I was thinking about this ticket today. Regarding Alan Bateman's comment that the pid may not be representable as an int/long, I was expecting some sort of Pid-like-object to be returned. I'd rather see an abstraction that *might* be able to convert into an int/long ... or even a String, as Martin

Re: RFR 9: 8003488 Add Process.getPid

2014-05-12 Thread Alan Bateman
On 12/05/2014 20:44, roger riggs wrote: Please review and comment on this long requested addition to provide the native process id of a spawned Process. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-getpid-8003488/ Issue: https://bugs.openjdk.java.net/browse/JDK-8003488 I think the