Re: RFR 9: 8149750 Decouple sun.misc.Signal from the base module

2016-02-18 Thread David Holmes
On 18/02/2016 11:54 AM, David Holmes wrote: On 18/02/2016 1:49 AM, Roger Riggs wrote: Hi David, On 2/17/2016 3:33 AM, David Holmes wrote: Hi Roger, On 17/02/2016 7:37 AM, Roger Riggs wrote: Hi David, Webrev updated in place: http://cr.openjdk.java.net/~rriggs/webrev-signal-9149750/ Thanks

Re: RFR 9: 8149750 Decouple sun.misc.Signal from the base module

2016-02-18 Thread Chris Hegarty
On 16 Feb 2016, at 21:38, Roger Riggs wrote: > Hi Chris, > > Webrev updated in place: >http://cr.openjdk.java.net/~rriggs/webrev-signal-9149750/ Thanks Roger, I’m happy with the source changes. -Chris. > On 2/15/2016 6:22 AM, Chris Hegarty wrote: >> On 12/02/16 17:47, Roger Riggs wrote:

Re: RFR 9: 8149750 Decouple sun.misc.Signal from the base module

2016-02-17 Thread David Holmes
On 18/02/2016 1:49 AM, Roger Riggs wrote: Hi David, On 2/17/2016 3:33 AM, David Holmes wrote: Hi Roger, On 17/02/2016 7:37 AM, Roger Riggs wrote: Hi David, Webrev updated in place: http://cr.openjdk.java.net/~rriggs/webrev-signal-9149750/ Thanks for those tweaks. I'm still perplexed by th

Re: RFR 9: 8149750 Decouple sun.misc.Signal from the base module

2016-02-17 Thread Roger Riggs
Hi David, On 2/17/2016 3:33 AM, David Holmes wrote: Hi Roger, On 17/02/2016 7:37 AM, Roger Riggs wrote: Hi David, Webrev updated in place: http://cr.openjdk.java.net/~rriggs/webrev-signal-9149750/ Thanks for those tweaks. I'm still perplexed by the test. We established that for USR2, PIPE

Re: RFR 9: 8149750 Decouple sun.misc.Signal from the base module

2016-02-17 Thread David Holmes
Hi Roger, On 17/02/2016 7:37 AM, Roger Riggs wrote: Hi David, Webrev updated in place: http://cr.openjdk.java.net/~rriggs/webrev-signal-9149750/ Thanks for those tweaks. I'm still perplexed by the test. We established that for USR2, PIPE and XFSZ the handler is not actually invoked - yet yo

Re: RFR 9: 8149750 Decouple sun.misc.Signal from the base module

2016-02-16 Thread Roger Riggs
Hi David, Webrev updated in place: http://cr.openjdk.java.net/~rriggs/webrev-signal-9149750/ On 2/14/2016 11:55 PM, David Holmes wrote: Hi Roger, A few mostly minor comments ... On 13/02/2016 3:47 AM, Roger Riggs wrote: Please review moving the functionality of sun.misc.Signal to jdk.inte

Re: RFR 9: 8149750 Decouple sun.misc.Signal from the base module

2016-02-16 Thread Roger Riggs
Hi Chris, Webrev updated in place: http://cr.openjdk.java.net/~rriggs/webrev-signal-9149750/ On 2/15/2016 6:22 AM, Chris Hegarty wrote: On 12/02/16 17:47, Roger Riggs wrote: Please review moving the functionality of sun.misc.Signal to jdk.internal.misc and creating a wrapper sun.misc.Signal

Re: RFR 9: 8149750 Decouple sun.misc.Signal from the base module

2016-02-15 Thread Chris Hegarty
On 12/02/16 17:47, Roger Riggs wrote: Please review moving the functionality of sun.misc.Signal to jdk.internal.misc and creating a wrapper sun.misc.Signal for existing external uses. +++ This time including the hotspot changes to update the target of the upcalls. A new replacement API will be

Re: RFR 9: 8149750 Decouple sun.misc.Signal from the base module

2016-02-14 Thread David Holmes
Hi Roger, A few mostly minor comments ... On 13/02/2016 3:47 AM, Roger Riggs wrote: Please review moving the functionality of sun.misc.Signal to jdk.internal.misc and creating a wrapper sun.misc.Signal for existing external uses. +++ This time including the hotspot changes to update the target

RFR 9: 8149750 Decouple sun.misc.Signal from the base module

2016-02-12 Thread Roger Riggs
Please review moving the functionality of sun.misc.Signal to jdk.internal.misc and creating a wrapper sun.misc.Signal for existing external uses. +++ This time including the hotspot changes to update the target of the upcalls. A new replacement API will be considered separately. The update i

RFR 9: 8149750 Decouple sun.misc.Signal from the base module

2016-02-12 Thread Roger Riggs
Please review moving the functionality of sun.misc.Signal to jdk.internal.misc and creating a wrapper sun.misc.Signal for existing external uses. A new replacement API will be considered separately. The update includes a test that passes with or without the changes. (Except for an NPE instead of