Re: RFR JDK-8003245

2013-05-30 Thread Chris Hegarty
, kdf, J); if (fieldID == NULL) { return ckParam; } - Original Message - From: fwei...@redhat.com To: john.zavg...@oracle.com Cc: core-libs-dev@openjdk.java.net Sent: Wednesday, March 27, 2013 11:48:57 AM GMT -05:00 US/Canada Eastern Subject: Re: RFR JDK-8003245 On 03/20/2013 04:27 PM

Re: RFR JDK-8003245

2013-03-28 Thread Florian Weimer
On 03/27/2013 05:30 PM, John Zavgren wrote: Yes, the uninitialized memory will be accessed in some cases, for example: Okay, in this case, the changes look okay to me (although returning structures by value is somewhat unusual, but that's obviously a pre-existing issue). -- Florian Weimer

Re: RFR JDK-8003245

2013-03-27 Thread Florian Weimer
On 03/20/2013 04:27 PM, John Zavgren wrote: Please consider the following changes that eliminate the use of uninitialized memory. http://cr.openjdk.java.net/~jzavgren/8003245/webrev.01/ Is the uninitialized memory accessed on the error paths? -- Florian Weimer / Red Hat Product Security

Re: RFR JDK-8003245

2013-03-27 Thread John Zavgren
ckParam; } - Original Message - From: fwei...@redhat.com To: john.zavg...@oracle.com Cc: core-libs-dev@openjdk.java.net Sent: Wednesday, March 27, 2013 11:48:57 AM GMT -05:00 US/Canada Eastern Subject: Re: RFR JDK-8003245 On 03/20/2013 04:27 PM, John Zavgren wrote: Please consider

RFR JDK-8003245

2013-03-20 Thread John Zavgren
Greetings: Please consider the following changes that eliminate the use of uninitialized memory. http://cr.openjdk.java.net/~jzavgren/8003245/webrev.01/ Thanks! John