On 08/08/2013 09:10 AM, Paul Sandoz wrote:
On Aug 7, 2013, at 4:56 PM, Martin Buchholz wrote:
Doug is also working on HashMap, with experimental version in jsr166 CVS.
I think here:
http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/dl/java/util/HashMap.java?view=co
Right.
IMHO i think
On Aug 7, 2013, at 4:56 PM, Martin Buchholz wrote:
> Doug is also working on HashMap, with experimental version in jsr166 CVS.
> I think here:
> http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/dl/java/util/HashMap.java?view=co
>
Right.
IMHO i think we should quickly commit this warni
Hi,
I did a before/after run with the changes using Doug Lea's MapCheck
microbenchmark [1]. I tested java.util.HashMap with Object, String, and
Integer types.
It should be mentioned this was a quick check for any major performance
changes: 2 iterations, run by hand on my own (relatively qui
On 08/07/2013 10:57 AM, Peter Levart wrote:
On 08/07/2013 12:23 AM, Dan Smith wrote:
On Aug 6, 2013, at 2:43 PM, Remi Forax
wrote:
On 08/06/2013 11:11 PM, Dan Smith wrote:
Please review this warnings cleanup.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8022442 (not
yet visible
On 08/07/2013 12:23 AM, Dan Smith wrote:
On Aug 6, 2013, at 2:43 PM, Remi Forax wrote:
On 08/06/2013 11:11 PM, Dan Smith wrote:
Please review this warnings cleanup.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8022442 (not yet
visible)
Webrev: http://cr.openjdk.java.net/~dlsmith/
On 08/07/2013 12:23 AM, Dan Smith wrote:
On Aug 6, 2013, at 2:43 PM, Remi Forax wrote:
On 08/06/2013 11:11 PM, Dan Smith wrote:
Please review this warnings cleanup.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8022442 (not yet
visible)
Webrev: http://cr.openjdk.java.net/~dlsmith/
On Aug 6, 2013, at 2:43 PM, Remi Forax wrote:
> On 08/06/2013 11:11 PM, Dan Smith wrote:
>> Please review this warnings cleanup.
>>
>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8022442 (not yet
>> visible)
>> Webrev: http://cr.openjdk.java.net/~dlsmith/8022442/webrev.00/
>>
>> —D
An intermediate result from an unnecessary refactoring. Thanks for catching.
—Dan
On Aug 6, 2013, at 3:10 PM, Brent Christian wrote:
> Looks fine to me, though I'm not a Reviewer (but I think I "contributed" a
> fair number of those warnings O:).
>
> One question: why was enext added?:
>
>
Looks fine to me, though I'm not a Reviewer (but I think I "contributed"
a fair number of those warnings O:).
One question: why was enext added?:
1249 Entry enext = (Entry) newTable[i];
1250 e.next = enext;
Thanks,
-Brent
On 8/6/13 2:11 PM, Dan Smith wrote:
Please review this warnings clea
Update: some minor changes are necessary to LinkedHashMap to be compatible with
the HashMap changes (HashMap is unchanged).
Webrev: http://cr.openjdk.java.net/~dlsmith/8022442/webrev.01/
I confirmed that the jdk_util tests pass.
—Dan
On Aug 6, 2013, at 2:11 PM, Dan Smith wrote:
> Please revi
On 08/06/2013 11:11 PM, Dan Smith wrote:
Please review this warnings cleanup.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8022442 (not yet
visible)
Webrev: http://cr.openjdk.java.net/~dlsmith/8022442/webrev.00/
—Dan
Hi Dan,
I've seen that you have introduce a common super interfa
Hi Dan,
Looks good; nice cleanup :-)
Thanks,
-Joe
On 08/06/2013 02:11 PM, Dan Smith wrote:
Please review this warnings cleanup.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8022442 (not yet
visible)
Webrev: http://cr.openjdk.java.net/~dlsmith/8022442/webrev.00/
—Dan
Please review this warnings cleanup.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8022442 (not yet
visible)
Webrev: http://cr.openjdk.java.net/~dlsmith/8022442/webrev.00/
—Dan
13 matches
Mail list logo
