On 08/05/15 13:13, Pavel Rappo wrote:
Here's the latest update:
http://cr.openjdk.java.net/~prappo/8029689/webrev.01/
The source changes look good to me Pavel.
Just a few minor comments on the test:
1) There is a trivial System.out on L143 that could be removed.
2) L157, is this refer
Here's the latest update:
http://cr.openjdk.java.net/~prappo/8029689/webrev.01/
-Pavel
> On 21 Apr 2015, at 09:08, Chris Hegarty wrote:
>
> On 21 Apr 2015, at 03:00, David Holmes wrote:
>
>> On 21/04/2015 1:24 AM, Chris Hegarty wrote:
>>>
>>> On 20/04/15 16:17, Lance Andersen wrote
On 21 Apr 2015, at 03:00, David Holmes wrote:
> On 21/04/2015 1:24 AM, Chris Hegarty wrote:
>>
>> On 20/04/15 16:17, Lance Andersen wrote:
>>> Hi Pavel,
>>>
>>> So we are just documenting/clarifying the current behavior from what I
>>> can tell from the change?
>>
>> Looking at the testcase, i
On 21/04/2015 1:24 AM, Chris Hegarty wrote:
On 20/04/15 16:17, Lance Andersen wrote:
Hi Pavel,
So we are just documenting/clarifying the current behavior from what I
can tell from the change?
Looking at the testcase, it passes with the current JDK 9 ( and 8 ), so
this is just documenting exi
On 20/04/15 16:17, Lance Andersen wrote:
Hi Pavel,
So we are just documenting/clarifying the current behavior from what I can tell
from the change?
Looking at the testcase, it passes with the current JDK 9 ( and 8 ), so
this is just documenting existing behavior.
> If so, this looks OK as
Hi Pavel,
So we are just documenting/clarifying the current behavior from what I can tell
from the change? If so, this looks OK assuming you have an approved CCC? The
test seems fine.
I am assuming there should not be any issues here but would be good to hear
from others on this change as we
Hi everyone,
Could you please review my change for JDK-8029689
http://cr.openjdk.java.net/~prappo/8029689/webrev.00/
---
There is a long-standing issue when platform implementations of java.io.Reader
throw IndexOutOfBou