Looks good to me.
Regards,
Sean.
On 02/12/17 01:04, Xueming Shen wrote:
On 12/1/17, 3:40 PM, Paul Sandoz wrote:
On 30 Nov 2017, at 14:46, Xueming Shen wrote:
Hi,
Please help review the change for JDK-8191918:
issue:
+1
This is a good example of where “var” can really reduce the verbosity, up to
you.
Also ByteArrayOutputStream.close is a no-op, you don’t need the finally block.
Paul.
> On 1 Dec 2017, at 17:04, Xueming Shen wrote:
>
> On 12/1/17, 3:40 PM, Paul Sandoz wrote:
>>
On 12/1/17, 3:40 PM, Paul Sandoz wrote:
On 30 Nov 2017, at 14:46, Xueming Shen wrote:
Hi,
Please help review the change for JDK-8191918:
issue: https://bugs.openjdk.java.net/browse/JDK-8191918
webrev: http://cr.openjdk.java.net/~sherman/8191918/webrev
> On 30 Nov 2017, at 14:46, Xueming Shen wrote:
>
> Hi,
>
> Please help review the change for JDK-8191918:
>
> issue: https://bugs.openjdk.java.net/browse/JDK-8191918
> webrev: http://cr.openjdk.java.net/~sherman/8191918/webrev
>
InflateIn_DeflateOut.java
—
174
Hi,
Please help review the change for JDK-8191918:
issue: https://bugs.openjdk.java.net/browse/JDK-8191918
webrev: http://cr.openjdk.java.net/~sherman/8191918/webrev
This is the backport/identical change we have already putback into
earlier update
releases for JDK-8189789. It includes two