Re: RFR JDK-8196987: Resolve disabled warnings for libzip

2018-05-21 Thread Alan Bateman
On 22/05/2018 03:41, Xueming Shen wrote: Hi Please help review the change for JDK-8196987. issue: https://bugs.openjdk.java.net/browse/JDK-8196987 webrev: http://cr.openjdk.java.net/~sherman/8196987/webrev It appears the change for JDK-6341887 in Deflater.c#169 "accidentally" fixed the offend

RFR JDK-8196987: Resolve disabled warnings for libzip

2018-05-21 Thread Xueming Shen
Hi Please help review the change for JDK-8196987. issue: https://bugs.openjdk.java.net/browse/JDK-8196987 webrev: http://cr.openjdk.java.net/~sherman/8196987/webrev It appears the change for JDK-6341887 in Deflater.c#169 "accidentally" fixed the offending "implicit-fallthrough" warning/error