Re: RFR of JDK-8214431: tests failed because can not find removed library folder at test/jdk/lib/testlibrary/jdk/testlibrary

Thanks, I'll do that. Cheers, Thomas On Thu, Nov 29, 2018, 06:00 David Holmes Hi Thomas, > > On 29/11/2018 2:37 pm, Thomas Stüfe wrote: > > Hi all, > > > > Will the failed test jobs be automatically re-submitted or should we do > > that manually? > > Do you mean for the submit-repo? > > I'd

Re: RFR of JDK-8214431: tests failed because can not find removed library folder at test/jdk/lib/testlibrary/jdk/testlibrary

Hi Thomas, On 29/11/2018 2:37 pm, Thomas Stüfe wrote: Hi all, Will the failed test jobs be automatically re-submitted or should we do that manually? Do you mean for the submit-repo? I'd pull/rebase to get all recent fixes as there was a Mac build fix that just went in too - then resubmit.

Re: RFR of JDK-8214431: tests failed because can not find removed library folder at test/jdk/lib/testlibrary/jdk/testlibrary

Hi all, Will the failed test jobs be automatically re-submitted or should we do that manually? Thanks, Thomas On Thu, Nov 29, 2018, 00:43 Hamlin Li Hi, > > Thank you for reviewing this, it's just pushed, I'm sorry for the > inconvenience. > > Thank you > > -Hamlin > > On 2018/11/29 5:12 AM,

Re: RFR of JDK-8214431: tests failed because can not find removed library folder at test/jdk/lib/testlibrary/jdk/testlibrary

Hi, Thank you for reviewing this, it's just pushed, I'm sorry for the inconvenience. Thank you -Hamlin On 2018/11/29 5:12 AM, Chris Hegarty wrote: I think this good. Thanks. -Chris. On 28 Nov 2018, at 20:32, David Holmes wrote: Hi Hamlin, On 28/11/2018 10:52 pm, Hamlin Li wrote: Hi

Re: RFR of JDK-8214431: tests failed because can not find removed library folder at test/jdk/lib/testlibrary/jdk/testlibrary

I think this good. Thanks. -Chris. > On 28 Nov 2018, at 20:32, David Holmes wrote: > > Hi Hamlin, > > On 28/11/2018 10:52 pm, Hamlin Li wrote: >> Hi David, >> Yes, they'd better be removed too, so I create another bug >> https://bugs.openjdk.java.net/browse/JDK-8214435 to track it. > > Ok.

Re: RFR of JDK-8214431: tests failed because can not find removed library folder at test/jdk/lib/testlibrary/jdk/testlibrary

Hi Hamlin, Change looks good, thanks for fixing this. Thanks, Christian > On Nov 28, 2018, at 4:52 AM, Hamlin Li wrote: > > Hi David, > > Yes, they'd better be removed too, so I create another bug > https://bugs.openjdk.java.net/browse/JDK-8214435 to track it. > > With only

Re: RFR of JDK-8214431: tests failed because can not find removed library folder at test/jdk/lib/testlibrary/jdk/testlibrary

Hi Hamlin, On 28/11/2018 10:52 pm, Hamlin Li wrote: Hi David, Yes, they'd better be removed too, so I create another bug https://bugs.openjdk.java.net/browse/JDK-8214435 to track it. Ok. With only /lib/testlibrary/, tests will not fail, tests only fail when there is something like "run

Re: RFR of JDK-8214431: tests failed because can not find removed library folder at test/jdk/lib/testlibrary/jdk/testlibrary

Just read the webrev, already covered :) -Leo On 11/28/18 9:09 PM, li.ji...@oracle.com wrote: Hi Hamlin, You can find some tests under sun/management/jmxremote/ failed on this issue too. Thanks, Leo On 11/28/18 7:15 PM, Hamlin Li wrote: Hi David, Thank a lot for double checking the

Re: RFR of JDK-8214431: tests failed because can not find removed library folder at test/jdk/lib/testlibrary/jdk/testlibrary

I think you mean bootstrap/PasswordFilePermissionTest.java bootstrap/SSLConfigFilePermissionTest.java startstop/JMXStatusPerfCountersTest.java startstop/JMXStatusTest.java. They have already been included in http://cr.openjdk.java.net/~mli/8214431/webrev.00/ Thank you -Hamlin On

Re: RFR of JDK-8214431: tests failed because can not find removed library folder at test/jdk/lib/testlibrary/jdk/testlibrary

Hi Hamlin, You can find some tests under sun/management/jmxremote/ failed on this issue too. Thanks, Leo On 11/28/18 7:15 PM, Hamlin Li wrote: Hi David, Thank a lot for double checking the usage of testlibrary. I have updated the patch, http://cr.openjdk.java.net/~mli/8214431/webrev.00/

Re: RFR of JDK-8214431: tests failed because can not find removed library folder at test/jdk/lib/testlibrary/jdk/testlibrary

Hi David, Yes, they'd better be removed too, so I create another bug https://bugs.openjdk.java.net/browse/JDK-8214435 to track it. With only /lib/testlibrary/, tests will not fail, tests only fail when there is something like "run build jdk.testlibrary.*" So, I think in this bug it's OK to

Re: RFR of JDK-8214431: tests failed because can not find removed library folder at test/jdk/lib/testlibrary/jdk/testlibrary

Hi Hamlin, On 28/11/2018 9:15 pm, Hamlin Li wrote: Hi David, Thank a lot for double checking the usage of testlibrary. I have updated the patch, http://cr.openjdk.java.net/~mli/8214431/webrev.00/ I'm not sure about the removal of /lib/testlibrary/ from @library /lib/testlibrary/

Re: RFR of JDK-8214431: tests failed because can not find removed library folder at test/jdk/lib/testlibrary/jdk/testlibrary

Hi David, Thank a lot for double checking the usage of testlibrary. I have updated the patch, http://cr.openjdk.java.net/~mli/8214431/webrev.00/ Thank you -Hamlin On 2018/11/28 6:24 PM, David Holmes wrote: Hi Hamlin, I see a lot more tests that look like they may be affected:

Re: RFR of JDK-8214431: tests failed because can not find removed library folder at test/jdk/lib/testlibrary/jdk/testlibrary

Hi Hamlin, I see a lot more tests that look like they may be affected: ./jdk/com/sun/tools/attach/TempDirTest.java: * @run build jdk.testlibrary.* Application RunnerUtil ./jdk/com/sun/tools/attach/PermissionTest.java: * @run build jdk.testlibrary.* Application

RFR of JDK-8214431: tests failed because can not find removed library folder at test/jdk/lib/testlibrary/jdk/testlibrary

Would you please review the following patch? This is a regression by JDK-8211975. bug: https://bugs.openjdk.java.net/browse/JDK-8214431 patch at the bottom. Thank you -Hamlin diff -r 70adb0f573a7