On 12/22/2013 08:40 PM, Brian Goetz wrote:
I can take on java.lang.
When your IDE tells you about "unnecessary boxing" in
Integer.valueOf(), or "inner class can be converted to lambda" in
LambdaMetafacory, don't believe it :)
I've found that bug recently, test with your favorite IDE:
R
I can take on java.lang.
When your IDE tells you about "unnecessary boxing" in Integer.valueOf(),
or "inner class can be converted to lambda" in LambdaMetafacory, don't
believe it :)
On Dec 19, 2013, at 5:44 PM, Brian Goetz wrote:
> +1 on all changes, except perhaps for this one in Collections.copy:
>
> ListIterator di=dest.listIterator();
> ListIterator si=src.listIterator();
> for (int i=0; i di.next();
> di.set(si
These look good to me.
On Dec 19 2013, at 06:51 , Paul Sandoz wrote:
> Hi,
>
> Here are some patches that migrate some code to use more up to date language
> features. I will create a bug later on after feedback.
>
> This is motivated from Brian's patches to lang tools.
>
> Compress catches
On 19/12/2013 14:51, Paul Sandoz wrote:
:
I ran all the j.u. tests locally and there were no regressions.
That's the main thing with changes like this.
I skimmed over the changes too and they look okay. I'm sometimes wary of
IDEs re-arranging things but there's nothing here. It would be good
I looked over the patch files, and they look good to me.
Limiting each webrev to a single language feature makes reviewing quite
straight forward.
-Chris.
On 19 Dec 2013, at 14:51, Paul Sandoz wrote:
> Hi,
>
> Here are some patches that migrate some code to use more up to date language
> fe
Paul deliberately stayed away from the JUC classes. Can we get a
definitive list of non-JUC classes that primarily live in the JSR166 CVS?
On 12/19/2013 11:48 AM, Martin Buchholz wrote:
(as always) Please don't modify jsr166 classes (ArrayDeque) here, since
they are maintained upstream in jsr1
+1 on all changes, except perhaps for this one in Collections.copy:
ListIterator di=dest.listIterator();
ListIterator si=src.listIterator();
for (int i=0; iThe code is bizarre enough (calling next based on a range loop rather
than hasNext()) to leave alone.
On 12/1
Hi Paul,
I looked at the modifications in java.util.logging and they
look both sensible and desirable.
Had to look at the code for Objects.toString(Object,Object) as
I had never used that before :-)
Thanks for taking care of that,
-- daniel
On 12/19/13 3:51 PM, Paul Sandoz wrote:
Hi,
Here
Hi,
Here are some patches that migrate some code to use more up to date language
features. I will create a bug later on after feedback.
This is motivated from Brian's patches to lang tools.
I focused just on java.util, minus the concurrent packages, and i used the IDE
to assist in the code mig
10 matches
Mail list logo
