Hi Hamlin,
Looks good. On to the next.
Roger
On 5/31/17 9:52 PM, Hamlin Li wrote:
Hi Roger,
Thank you for detailed reviewing, fixed as you suggested except below
comment:
81-83/93/95: use SHARE.resolve(xxx).toString to compute the paths.
As the code is constructing a class path wi
Hi Roger,
Thank you for detailed reviewing, fixed as you suggested except below
comment:
81-83/93/95: use SHARE.resolve(xxx).toString to compute the paths.
As the code is constructing a class path with 2 paths rather than
constructing a path.
new webrev: http://cr.openjdk.java.net/~m
Hi Hamlin,
RenamePackageTest.java:
- 48,61: rename "sutup" -> "setup"
81-83/93/95: use SHARE.resolve(xxx).toString to compute the paths.
ClassPathTest.java:
42: add a space before "{"
56: Generally, exception messages should not end in "."; they are phrases
so they could be printed with
Ping.
Thank you
-Hamlin
On 2017/5/27 9:14, Hamlin Li wrote:
Hi Roger,
Thank you for catching it, new webrev:
http://cr.openjdk.java.net/~mli/8166142/webrev.02/
Thank you
-Hamlin
On 2017/5/27 3:30, Roger Riggs wrote:
Hi Hamlin,
SubclassTest.java:37: typo" excepiton" -> exception
Sub
Hi Roger,
Thank you for catching it, new webrev:
http://cr.openjdk.java.net/~mli/8166142/webrev.02/
Thank you
-Hamlin
On 2017/5/27 3:30, Roger Riggs wrote:
Hi Hamlin,
SubclassTest.java:37: typo" excepiton" -> exception
SubclassDataLossTest.java:
103/104: Adding the class loader close()
Hi Hamlin,
SubclassTest.java:37: typo" excepiton" -> exception
SubclassDataLossTest.java:
103/104: Adding the class loader close() calls isn't very effective
since if there is an exception they are not
closed and the creation in a static initializer is mismatched with
main() code.
It would
Hi Roger,
Thank you for detailed review. Fixed as you suggested, new webrev:
http://cr.openjdk.java.net/~mli/8166142/webrev.01/
Thank you
-Hamlin
On 2017/5/26 2:54, Roger Riggs wrote:
Hi Hamlin,
For imports they should import specific classes, wildcards are not used.
maskSyntheticModifie
Hi Hamlin,
For imports they should import specific classes, wildcards are not used.
maskSyntheticModifier/Test.java
consTest/Test.java
deserializeButton/Test.java
test/java/io/Serializable/packageAccess/Driver.java: the name "Driver"
is not descriptive and should be.
Each Driver.java should
