Re: [8u] RFR: 8142543: Unformatted code example in API

2019-09-18 Thread Evgeny Mandrikov
On Wed, Sep 18, 2019 at 10:32 PM Aleksey Shipilev wrote: > On 9/18/19 10:23 PM, Evgeny Mandrikov wrote: > > So AFAIU from the above wiki page - first 8142543 should be closed as > dup of 8073347, > > For this case, I would comment in JDK-8142543 that JDK-8073347 fixes the > same thing, without cl

Re: [8u] RFR: 8142543: Unformatted code example in API

2019-09-18 Thread Aleksey Shipilev
On 9/18/19 10:23 PM, Evgeny Mandrikov wrote: > So AFAIU from the above wiki page - first 8142543 should be closed as dup of  > 8073347, For this case, I would comment in JDK-8142543 that JDK-8073347 fixes the same thing, without closing as dup yet. Then finish the backport, then maybe close as d

Re: [8u] RFR: 8142543: Unformatted code example in API

2019-09-18 Thread Evgeny Mandrikov
On Wed, Sep 18, 2019 at 9:38 PM Aleksey Shipilev wrote: > On 9/18/19 9:29 PM, Evgeny Mandrikov wrote: > > Hello, > > > > Please review this 8u backport [1] of JDK-8073347 [2] that resolves > > JDK-8142543 [3]. > > Wait, that's not how it works, sorry. Please read this: > https://wiki.openjdk.ja

Re: [8u] RFR: 8142543: Unformatted code example in API

2019-09-18 Thread Aleksey Shipilev
On 9/18/19 9:29 PM, Evgeny Mandrikov wrote: > Hello, > > Please review this 8u backport [1] of JDK-8073347 [2] that resolves > JDK-8142543 [3]. Wait, that's not how it works, sorry. Please read this: https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix Since you are backpor