Re: [8u40] RFR 6642881: Improve performance of Class.getClassLoader()

2016-07-29 Thread David Holmes
On 29/07/2016 5:55 PM, Leela Mohan wrote: Hi David, I understand, Klass types are no longer oops but JNIHandles::resolve_non_null() would expose naked oops. In other words, KlassOops are no longer oops but java.lang.Class objects are. Yes my mistake - focusing on the wrong aspect. Good

Re: [8u40] RFR 6642881: Improve performance of Class.getClassLoader()

2016-07-29 Thread Leela Mohan
I think, change in the file unsafe.cpp is incorrect. ( http://cr.openjdk.java.net/~coleenp/6642881_8u40_hotspot/ ) Below function is accessing naked oops when thread has transitioned to "native": *+ static jobject get_class_loader(JNIEnv* env, jclass cls) {**+ if

Re: [8u40] RFR 6642881: Improve performance of Class.getClassLoader()

2016-07-29 Thread Leela Mohan
Hi David, I understand, Klass types are no longer oops but JNIHandles::resolve_non_null() would expose naked oops. In other words, KlassOops are no longer oops but java.lang.Class objects are. Thanks, Leela On Thu, Jul 28, 2016 at 10:51 PM, David Holmes wrote: > Hi

Re: [8u40] RFR 6642881: Improve performance of Class.getClassLoader()

2016-07-28 Thread David Holmes
Hi Leela, On 29/07/2016 12:59 PM, Leela Mohan wrote: I think, change in the file unsafe.cpp is incorrect. ( http://cr.openjdk.java.net/~coleenp/6642881_8u40_hotspot/ ) Below function is accessing naked oops when thread has transitioned to "native": *+ static jobject get_class_loader(JNIEnv*

Re: [8u40] RFR 6642881: Improve performance of Class.getClassLoader()

2014-09-08 Thread Coleen Phillimore
Thanks David! Coleen On 9/7/14, 9:38 PM, David Holmes wrote: Looks okay to me. David On 6/09/2014 5:55 AM, Coleen Phillimore wrote: Summary: Add classLoader to java/lang/Class instance for fast access This is a backport request for 8u40. This change has been in the jdk9 code for 3 months

Re: [8u40] RFR 6642881: Improve performance of Class.getClassLoader()

2014-09-08 Thread Coleen Phillimore
Thanks, Mandy! Coleen On 9/8/14, 6:59 PM, Mandy Chung wrote: Thumbs up. Mandy On 9/5/2014 12:55 PM, Coleen Phillimore wrote: Summary: Add classLoader to java/lang/Class instance for fast access This is a backport request for 8u40. This change has been in the jdk9 code for 3 months

Re: [8u40] RFR 6642881: Improve performance of Class.getClassLoader()

2014-09-07 Thread David Holmes
Looks okay to me. David On 6/09/2014 5:55 AM, Coleen Phillimore wrote: Summary: Add classLoader to java/lang/Class instance for fast access This is a backport request for 8u40. This change has been in the jdk9 code for 3 months without any problems. The JDK changes hg imported cleanly.