-
From: Kumar Srinivasan
Sent: December 12, 2019 8:32 AM
To: Henry Jen
Cc: core-libs-dev@openjdk.java.net; Nikola Grcevski
Subject: Re: [EXTERNAL] JDK-8234076 bug fix candidate
Hi Henry,
I approve this. Appreciate you pushing it, as usual *all* possible tests need
to be run. ;)
Nikola
>> +// We should be able to find the argument --help as an application
>> argument
>> +ProcessTools.executeProcess(
>> +createProcessWithLauncherDebugging(
>> +"--module-path=" + dir,
>> +"-
S_WINDOWS) {
>> +return;
>> +}
>> +
>> +String dir = MODS_DIR.toString();
>> +String mid = TEST_MODULE + "/" + MAIN_CLASS;
>> +
>> + // java --module-path=mods --module=$TESTMODULE/$MAINCLASS --help
>> +
SRC_DIR.resolve(TEST_MODULE).toString() + "\\*.java",
> + "--help"))
> + .outputTo(System.out)
> +.errorTo(System.out)
> +.shouldContain("F--help")
> +.shouldContain(&quo
t; + dir,
> +"--module=" + mid,
> +SRC_DIR.resolve(TEST_MODULE).toString() + "\\*.java",
> +"--help"))
> + .outputTo(System.out)
> +.errorTo(System.out)
> +.shouldContain(&q
// deemed as application arguments
+OutputAnalyzer output = ProcessTools.executeProcess(
+createProcessWithLauncherDebugging(
+ "--module-path=" + dir,
+"--module=" + mid,
+"--module-path=" + dir,
+
ProcessWithLauncherDebugging(
> +"--module-path=" + dir,
> +"--module=" + mid,
> + SRC_DIR.resolve(TEST_MODULE).toString() + "\\*.java",
> +"--help"))
> +.outputTo(System.o
e
second pair of module-path and module will be
+// deemed as application arguments
+OutputAnalyzer output = ProcessTools.executeProcess(
+createProcessWithLauncherDebugging(
+ "--module-path=" + dir,
+"--module=" + mid,
+
DULE/$MAINCLASS
> > +// The first --module= will terminate the VM arguments
> processing. The second pair of module-path and module will be
> > + // deemed as application arguments
> > +OutputAnalyzer output = ProcessTools.executeProcess(
> > +
;--module-path=" + dir,
> +"--module=" + mid,
> +"--module-path=" + dir,
> +"--module=" + mid))
> +.outputTo(System.out)
> + .errorTo(System.out)
> +.shouldContain("argv
ll not work as --module= is terminating and the
module will be not found
+ int exitValue = exec("--module=" + mid, "--module-path" + dir);
+assertTrue(exitValue != 0);
+}
}
-Original Message-
From: Henry Jen
Sent: December 6, 2019 12:03 AM
To:
usage.
>
> Thank you,
> Nikola
>
> -Original Message-
> From: Henry Jen
> Sent: December 4, 2019 8:26 PM
> To: Kumar Srinivasan ; Alan Bateman
> ; Nikola Grcevski
> Cc: core-libs-dev@openjdk.java.net
> Subject: Re: [EXTERNAL] JDK-8234076 bug fix candidate
>
module usage.
Thank you,
Nikola
-Original Message-
From: Henry Jen
Sent: December 4, 2019 8:26 PM
To: Kumar Srinivasan ; Alan Bateman
; Nikola Grcevski
Cc: core-libs-dev@openjdk.java.net
Subject: Re: [EXTERNAL] JDK-8234076 bug fix candidate
> On Dec 4, 2019, at 1:15 PM, Kumar Sri
inal Message-
> From: Henry Jen
> Sent: December 3, 2019 11:39 AM
> To: Kumar Srinivasan
> Cc: Nikola Grcevski ; Alan Bateman
> ; core-libs-dev@openjdk.java.net
> Subject: Re: [EXTERNAL] JDK-8234076 bug fix candidate
>
> Kumar,
>
> Great to have you look at this,
; From: Henry Jen
> Sent: December 3, 2019 11:39 AM
> To: Kumar Srinivasan
> Cc: Nikola Grcevski ; Alan Bateman <
> alan.bate...@oracle.com>; core-libs-dev@openjdk.java.net
> Subject: Re: [EXTERNAL] JDK-8234076 bug fix candidate
>
> Kumar,
>
> Great to have you l
-8234076 bug fix candidate
Kumar,
Great to have you look at this, you are correct, this patch doesn’t address the
wildcard expansion issue, but only to address the potential crash if a main
class is not specified as Nikola pointed out.
We definitely need a follow up to fix wildcard expansion
Kumar,
Great to have you look at this, you are correct, this patch doesn’t address the
wildcard expansion issue, but only to address the potential crash if a main
class is not specified as Nikola pointed out.
We definitely need a follow up to fix wildcard expansion. The pointer to
simplify
17 matches
Mail list logo
