Re: [PATCH] Trivial improvement for j.l.Character.toString() - 8241649: Optimize Character.toString

2020-04-06 Thread Claes Redestad
Good catch. Closed it as duplicate - also surprised myself that I didn't find this one when I did a cursory search in JBS for pre-existing issues. /Claes On 2020-04-06 07:24, Anirvan Sarkar wrote: JDK-8189375 should be closed as duplicate. On

Re: [PATCH] Trivial improvement for j.l.Character.toString() - 8241649: Optimize Character.toString

2020-04-05 Thread Anirvan Sarkar
JDK-8189375 should be closed as duplicate. On Thu, 26 Mar 2020 at 18:06, Claes Redestad wrote: > Filed and pushed: https://bugs.openjdk.java.net/browse/JDK-8241649 > > /Claes > > On 2020-03-26 00:12, Roger Riggs wrote: > > Agreed, +1 > > > > O

Re: [PATCH] Trivial improvement for j.l.Character.toString() - 8241649: Optimize Character.toString

2020-03-26 Thread Claes Redestad
Filed and pushed: https://bugs.openjdk.java.net/browse/JDK-8241649 /Claes On 2020-03-26 00:12, Roger Riggs wrote: Agreed,  +1 On 3/25/20 5:53 PM, Claes Redestad wrote: Looks good and trivial, including the drive-by cleanups. I can sponsor. /Claes On 2020-03-25 22:18, Сергей Цыпанов wrote:

Re: [PATCH] Trivial improvement for j.l.Character.toString()

2020-03-25 Thread Roger Riggs
Agreed,  +1 On 3/25/20 5:53 PM, Claes Redestad wrote: Looks good and trivial, including the drive-by cleanups. I can sponsor. /Claes On 2020-03-25 22:18, Сергей Цыпанов wrote: Hello, I think we can reduce allocation rate for j.l.Character.toString() by calling String.valueOf(char) instead

Re: [PATCH] Trivial improvement for j.l.Character.toString()

2020-03-25 Thread Claes Redestad
Looks good and trivial, including the drive-by cleanups. I can sponsor. /Claes On 2020-03-25 22:18, Сергей Цыпанов wrote: Hello, I think we can reduce allocation rate for j.l.Character.toString() by calling String.valueOf(char) instead of String.valueOf(char[]). Current implementation creat