On 12/12/2018 16:52, Magnus Ihse Bursie wrote:
On 2018-12-12 16:34, Alexey Ivanov wrote:
On 12/12/2018 12:58, Magnus Ihse Bursie wrote:
On 2018-12-12 12:35, Alan Bateman wrote:
On 12/12/2018 11:14, Magnus Ihse Bursie wrote:
:
I searched the code for "jdwpTransport_On" to see of there
On 2018-12-12 16:34, Alexey Ivanov wrote:
On 12/12/2018 12:58, Magnus Ihse Bursie wrote:
On 2018-12-12 12:35, Alan Bateman wrote:
On 12/12/2018 11:14, Magnus Ihse Bursie wrote:
:
I searched the code for "jdwpTransport_On" to see of there was any
corresponding OnUnload function (or other)
Hi Simon,
I'd like to clarify some points…
Please see my comments inline:
On 11/12/2018 17:16, Alexey Ivanov wrote:
Hi Simon,
Thank you for your comments.
The updated webrev:
http://cr.openjdk.java.net/~aivanov/8214122/webrev.01/
Indeed, it looks much cleaner.
Regards,
Alexey
On 11/12/2018
Hi Bob,
Thank you for the pointers on how the same situation is handled in
Hotspot for *_OnLoad* functions.
At this time, we're dealing with one symbol only. If other symbols are
added in the future, we should definitely use this approach.
Regards,
Alexey
On 11/12/2018 17:22, Bob Vandette
On 12/12/2018 12:58, Magnus Ihse Bursie wrote:
On 2018-12-12 12:35, Alan Bateman wrote:
On 12/12/2018 11:14, Magnus Ihse Bursie wrote:
:
I searched the code for "jdwpTransport_On" to see of there was any
corresponding OnUnload function (or other), but could not find any.
That's right, an
On 2018-12-12 12:35, Alan Bateman wrote:
On 12/12/2018 11:14, Magnus Ihse Bursie wrote:
:
I searched the code for "jdwpTransport_On" to see of there was any
corresponding OnUnload function (or other), but could not find any.
That's right, an unload wasn't needed when that SPI was originally
On 12/12/2018 11:14, Magnus Ihse Bursie wrote:
:
I searched the code for "jdwpTransport_On" to see of there was any
corresponding OnUnload function (or other), but could not find any.
That's right, an unload wasn't needed when that SPI was originally added
but could be added in the event that
On 2018-12-11 18:16, Alexey Ivanov wrote:
Hi Simon,
Thank you for your comments.
The updated webrev:
http://cr.openjdk.java.net/~aivanov/8214122/webrev.01/
Indeed, it looks much cleaner.
Yes! This seems like the correct fix.
Ship it! :)
/Magnus
Regards,
Alexey
On 11/12/2018 16:43, Si
On 2018-12-11 18:22, Bob Vandette wrote:
Hotspot has had support for decorated and non-decorated names for the JNI_OnLoad
functions. Perhaps you should just follow the same procedure for the debug
library.
#define JNI_ONLOAD_SYMBOLS {"_JNI_OnLoad@8", "JNI_OnLoad"}
#define JNI_ONUNLOAD_SYMBOLS
Hotspot has had support for decorated and non-decorated names for the JNI_OnLoad
functions. Perhaps you should just follow the same procedure for the debug
library.
#define JNI_ONLOAD_SYMBOLS {"_JNI_OnLoad@8", "JNI_OnLoad"}
#define JNI_ONUNLOAD_SYMBOLS {"_JNI_OnUnload@8", "JNI_OnUnload"}
#defi
Hi Simon,
Thank you for your comments.
The updated webrev:
http://cr.openjdk.java.net/~aivanov/8214122/webrev.01/
Indeed, it looks much cleaner.
Regards,
Alexey
On 11/12/2018 16:43, Simon Tooke wrote:
On 2018-12-11 10:05 a.m., Alexey Ivanov wrote:
Hi everyone,
I came up with the following
On 2018-12-11 10:05 a.m., Alexey Ivanov wrote:
> Hi everyone,
>
> I came up with the following patch:
> http://cr.openjdk.java.net/~aivanov/8214122/webrev.00/
>
> It specifically addresses the problem in JDK-8214122 where on 32 bit
> Windows jdwpTransport_OnLoad can exported with its plain and
> __
Hi everyone,
I came up with the following patch:
http://cr.openjdk.java.net/~aivanov/8214122/webrev.00/
It specifically addresses the problem in JDK-8214122 where on 32 bit
Windows jdwpTransport_OnLoad can exported with its plain and
__stdcall-mangled name. I used conditional compilation so th
vercomplicated to export one function or two. The calling convention
>>>>> of exported functions for JVM cannot be changed, they can be called
>>>>> from third-party software.
>>>>>
>>>>> If the function is used internally-only, its calling
gt;> -Original Message-----
>> From: core-libs-dev On
>> Behalf Of Ali Ince
>> Sent: Monday, November 19, 2018 2:08 PM
>> To: Alexey Ivanov ; build-dev
>> ; core-libs
>> Subject: Re: [PATCH] Windows 32-bit DLL name decoration
>>
>> Hi Alexey,
>
omeone who knows this area better
than me might want to comment...). Shouldn't the same approach be
taken here as well?
Thanks
Andrew
-Original Message-
From: core-libs-dev On
Behalf Of Ali Ince
Sent: Monday, November 19, 2018 2:08 PM
To: Alexey Ivanov; build-dev
; core-libs
Subje
er
than me might want to comment...). Shouldn't the same approach be
taken here as well?
Thanks
Andrew
-Original Message-
From: core-libs-dev On
Behalf Of Ali Ince
Sent: Monday, November 19, 2018 2:08 PM
To: Alexey Ivanov; build-dev
; core-libs
Subject: Re: [PATCH] Windows 32-bit DLL
H] Windows 32-bit DLL name decoration
Hi Alexey,
I don’t have an account on JBS as I’m not an author yet, my OCA has just been
processed. Would it be possible for someone with an author status to create an
issue?
Regards,
Ali
On 19 Nov 2018, at 12:12, Alexey Ivanov wrote:
Hi Ali,
The fix
rew
-Original Message-
From: core-libs-dev On
Behalf Of Ali Ince
Sent: Monday, November 19, 2018 2:08 PM
To: Alexey Ivanov ; build-dev
; core-libs
Subject: Re: [PATCH] Windows 32-bit DLL name decoration
Hi Alexey,
I don’t have an account on JBS as I’m not an author yet, my OCA has
jus
To: Alexey Ivanov ; build-dev ;
core-libs
Subject: Re: [PATCH] Windows 32-bit DLL name decoration
Hi Alexey,
I don’t have an account on JBS as I’m not an author yet, my OCA has just been
processed. Would it be possible for someone with an author status to create an
issue?
Regards,
Ali
On 1
d-dev
; core-libs
Subject: Re: [PATCH] Windows 32-bit DLL name decoration
Hi Alexey,
I don’t have an account on JBS as I’m not an author yet, my OCA has just been
processed. Would it be possible for someone with an author status to create an
issue?
Regards,
Ali
> On 19 Nov 2018, at 12:12
Hi Alexey,
I don’t have an account on JBS as I’m not an author yet, my OCA has just been
processed. Would it be possible for someone with an author status to create an
issue?
Regards,
Ali
> On 19 Nov 2018, at 12:12, Alexey Ivanov wrote:
>
> Hi Ali,
>
> The fix looks good to me provided it
Hi Ali,
The fix looks good to me provided it resolves your problem.
I am not a reviewer so you'll have to get OK from reviewers, likely from
build-dev and from core-libs.
Have you submitted the issue in JBS?
You have to sign OCA to be able to contribute to OpenJDK:
https://openjdk.java.net/co
23 matches
Mail list logo
