Re: [PATCH] improve javadoc in TreeSet#add api documentation

2018-12-21 Thread Stuart Marks
Hi Kishor, I took a look at the patch you sent. It looks like it was created against an older repository, paerhaps jdk8u-dev. We don't make spec changes to the older releases. Please base your changes on the latest mainline repository, which is http://hg.openjdk.java.net/jdk/jdk/ Notably

Re: [PATCH] improve javadoc in TreeSet#add api documentation

2018-12-17 Thread Kishor Gollapalliwar
Hello Stuart, Kindly find the diff file attached for your reference. Request you to review and provide your feedback. Once we finalize SortedSet, I'll start to enhance TreeSet documentation. Thank you, Kishor Gollapalliwar On Tue, Dec 18, 2018 at 4:13 AM Stuart Marks wrote: > Hi Kishor, > > N

Re: [PATCH] improve javadoc in TreeSet#add api documentation

2018-12-17 Thread Stuart Marks
Hi Kishor, No problem about the delay; I've certainly contributed to delays myself. And certainly I have an unbounded queue of things I'm working on myself at the moment. And no, it's not too late for this work! In the past, if you missed a JDK deadline, you might have to wait three years for

Re: [PATCH] improve javadoc in TreeSet#add api documentation

2018-12-13 Thread Kishor Gollapalliwar
Hello Stuart, Forgive me for delayed response. I was not well for a week, due to which lot of work got queued up in office. It took a while to sort it out. Your guidance was really helpful. And by end of this week I'll share first patch, containing document enhancements for SortedSet class. Hope

Re: [PATCH] improve javadoc in TreeSet#add api documentation

2018-11-29 Thread Stuart Marks
On 11/1/18 8:12 PM, Kishor Gollapalliwar wrote: Thank you for providing this opportunity. I'm up for this challenge and I'd love to take this task. The only huddle would be, how to proceed, ie planning things step by step, as this is my first time. If you can help me with the planning, I'll do th

Re: [PATCH] improve javadoc in TreeSet#add api documentation

2018-11-01 Thread Kishor Gollapalliwar
Hello Stuart, Thank you for providing this opportunity. I'm up for this challenge and I'd love to take this task. The only huddle would be, how to proceed, ie planning things step by step, as this is my first time. If you can help me with the planning, I'll do the rest and fix these issues. Th

Re: [PATCH] improve javadoc in TreeSet#add api documentation

2018-11-01 Thread Stuart Marks
Hi Kishor, This is indeed an issue with the documentation. The root of the issue is that the implementations of the SortedSet and SortMap interfaces do not use the equals() method to determine set or map membership. Instead they use a comparison method (a Comparator, if provided, or the object