Re: [Ping] Re: 8249703: test/jdk/java/io/File/GetXSpace.java fails on macos

2020-08-07 Thread Brian Burkhalter
Thanks for the review! Brian > On Aug 7, 2020, at 11:04 AM, naoto.s...@oracle.com wrote: > > Looks good. Thank you for the change.

Re: [Ping] Re: 8249703: test/jdk/java/io/File/GetXSpace.java fails on macos

2020-08-07 Thread naoto . sato
Looks good. Thank you for the change. Naoto On 8/7/20 10:57 AM, Brian Burkhalter wrote: Hi Naoto, Good point. Here’s an updated version: http://cr.openjdk.java.net/~bpb/8249703/webrev.01/. The number of blocks is not available via a dedicated API call and so has to be calculated. Thanks, B

Re: [Ping] Re: 8249703: test/jdk/java/io/File/GetXSpace.java fails on macos

2020-08-07 Thread Brian Burkhalter
Hi Naoto, Good point. Here’s an updated version: http://cr.openjdk.java.net/~bpb/8249703/webrev.01/. The number of blocks is not available via a dedicated API call and so has to be calculated. Thanks, Brian > On Aug 7, 2020, at 9:58 AM, naoto.s...@oracle.com wrote: > > Looks fine, Brian. >

Re: [Ping] Re: 8249703: test/jdk/java/io/File/GetXSpace.java fails on macos

2020-08-07 Thread naoto . sato
Looks fine, Brian. I might add the condition if the block number is odd. Naoto On 8/7/20 8:33 AM, Brian Burkhalter wrote: On Jul 31, 2020, at 10:42 AM, Brian Burkhalter wrote: On macOS, the number of 1024 byte blocks appears to be incorrectly calculated by 'df' using integer division by