Re: 8006409: ThreadLocalRandom should dropping padding fields from its serialized form

2013-02-27 Thread Chris Hegarty
On 02/27/2013 05:10 PM, Martin Buchholz wrote: CVS has been updated with some more internal doc clarifications. http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/main/java/util/concurrent/ThreadLocalRandom.java?view=co Thanks Martin, Once the CCC approves these changes, I will push them

Re: 8006409: ThreadLocalRandom should dropping padding fields from its serialized form

2013-02-27 Thread Martin Buchholz
CVS has been updated with some more internal doc clarifications. http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/main/java/util/concurrent/ThreadLocalRandom.java?view=co Martin's "random" wishlist: - I wish the cool convenience methods in TLR like nextInt(least, bound) could be promoted t

Re: 8006409: ThreadLocalRandom should dropping padding fields from its serialized form

2013-02-25 Thread Chris Hegarty
Thanks Martin, good suggestion. -Chris On 25 Feb 2013, at 22:25, Martin Buchholz wrote: > Perhaps slightly better is this variant, which adds doc for the > @serialField's. > > /** > * @serialField rnd long > * seed for random computations > * @serialField initi

Re: 8006409: ThreadLocalRandom should dropping padding fields from its serialized form

2013-02-25 Thread Martin Buchholz
Perhaps slightly better is this variant, which adds doc for the @serialField's. /** * @serialField rnd long * seed for random computations * @serialField initialized boolean * always true */ private static final ObjectStreamField[] serialP

Re: 8006409: ThreadLocalRandom should dropping padding fields from its serialized form

2013-02-25 Thread Martin Buchholz
Me too!

Re: 8006409: ThreadLocalRandom should dropping padding fields from its serialized form

2013-02-25 Thread Aleksey Shipilev
On 02/26/2013 01:46 AM, Chris Hegarty wrote: > [ Subject: 8006409: ThreadLocalRandom should drop padding fields > from its serialized form (was: Re: RFR (S): CR 8005926: (thread) > Merge ThreadLocalRandom state into java.lang.Thread) ] > > I think we are in agreement that the pad fields can sa

Re: 8006409: ThreadLocalRandom should dropping padding fields from its serialized form

2013-02-25 Thread Alan Bateman
On 25/02/2013 21:46, Chris Hegarty wrote: [ Subject: 8006409: ThreadLocalRandom should drop padding fields from its serialized form (was: Re: RFR (S): CR 8005926: (thread) Merge ThreadLocalRandom state into java.lang.Thread) ] I think we are in agreement that the pad fields can safely be rem

Re: 8006409: ThreadLocalRandom should dropping padding fields from its serialized form

2013-02-25 Thread Doug Lea
On 02/25/13 16:46, Chris Hegarty wrote: [ Subject: 8006409: ThreadLocalRandom should drop padding fields from its serialized form (was: Re: RFR (S): CR 8005926: (thread) Merge ThreadLocalRandom state into java.lang.Thread) ] I think we are in agreement that the pad fields can safely be rem