Re: 8251989: Unified Hex formatting and parsing utility

2020-09-28 Thread Brian Goetz
Minor nit:     Appendable foo(Appendable bar) should be     A foo(A bar) That way, if you say     hex.formatHex(aStringBuilder, bytes)    .foo() where foo() is a method on StringBuilder but not on Appendable, it will still work as expected. On 9/28/2020 11:32 AM, Roger Riggs wrote: A

Re: 8251989: Unified Hex formatting and parsing utility

2020-09-28 Thread Roger Riggs
After some reflection on the comments, suggestions, and other advice offered the Hex format API has undergone a significant rewrite. The improvements include:  - Merged format and parse classes into a single class HexFormat that holds parameters and has methods for all conversions  - Simplified