Re: A few char-fiddling optimizations for Pattern.java

2010-04-16 Thread Ulf Zibis
Am 16.04.2010 10:48, schrieb Ulf Zibis: On a 2nd thought, I think a code point in the surrogate range should be rare, as it is kinda invalid. So why check it in 1. place. What is the purpose of the method? - isNotValidOrSurrogateBMPCodePoint --> includes negative and values > MAX_SUPPLEMENTARY_

Re: A few char-fiddling optimizations for Pattern.java

2010-04-16 Thread Ulf Zibis
Am 16.04.2010 02:52, schrieb Martin Buchholz: On Thu, Apr 15, 2010 at 17:23, Ulf Zibis wrote: Hi Xueming and Ulf, Please review a few more optimizations to be added to the current crop: http://cr.openjdk.java.net/~martin/webrevs/openjdk7/Pattern-opt/ Have you tried to disassemb

Re: A few char-fiddling optimizations for Pattern.java

2010-04-15 Thread Martin Buchholz
On Thu, Apr 15, 2010 at 17:23, Ulf Zibis wrote: >> >> Hi Xueming and Ulf, >> >> Please review a few more optimizations to be added to the >> current crop: >> >> http://cr.openjdk.java.net/~martin/webrevs/openjdk7/Pattern-opt/ >> >> > > Have you tried to disassemble? : No. Have you? >    private

Re: A few char-fiddling optimizations for Pattern.java

2010-04-15 Thread Ulf Zibis
Hi Xueming and Ulf, Please review a few more optimizations to be added to the current crop: http://cr.openjdk.java.net/~martin/webrevs/openjdk7/Pattern-opt/ Have you tried to disassemble? : private static final boolean isSupplementary(int cp) { returnCharacter.isSurrogate((