Re: Code Review Request: 7198073: (prefs) user prefs not saved [macosx]

2012-10-16 Thread Kurchi Subhra Hazra
On 10/16/12 2:54 AM, Alan Bateman wrote: On 16/10/2012 01:53, Kurchi Hazra wrote: Hi Alan, Please find an updated webrev with a test included: http://cr.openjdk.java.net/~khazra/7198073/webrev.01/ CheckUserPrefsStorage.sh is the main entry point - it runs CheckUserPrefFirst first (which

Re: Code Review Request: 7198073: (prefs) user prefs not saved [macosx]

2012-10-16 Thread Alan Bateman
On 16/10/2012 01:53, Kurchi Hazra wrote: Hi Alan, Please find an updated webrev with a test included: http://cr.openjdk.java.net/~khazra/7198073/webrev.01/ CheckUserPrefsStorage.sh is the main entry point - it runs CheckUserPrefFirst first (which creates and attempts to store a preferenc

Re: Code Review Request: 7198073: (prefs) user prefs not saved [macosx]

2012-10-15 Thread Kurchi Hazra
Hi Alan, Please find an updated webrev with a test included: http://cr.openjdk.java.net/~khazra/7198073/webrev.01/ CheckUserPrefsStorage.sh is the main entry point - it runs CheckUserPrefFirst first (which creates and attempts to store a preference), and then runs CheckUserPrefLater (which

Re: Code Review Request: 7198073: (prefs) user prefs not saved [macosx]

2012-10-12 Thread Kurchi Subhra Hazra
On 10/12/12 12:43 AM, Alan Bateman wrote: On 12/10/2012 01:21, Kurchi Hazra wrote: Hi, This is a regression introduced by the fix for 7160252[1] that I pushed a few weeks ago. We should really be using the class member field isUser, rather than the argument passed in the constructor as a p

Re: Code Review Request: 7198073: (prefs) user prefs not saved [macosx]

2012-10-12 Thread Alan Bateman
On 12/10/2012 01:21, Kurchi Hazra wrote: Hi, This is a regression introduced by the fix for 7160252[1] that I pushed a few weeks ago. We should really be using the class member field isUser, rather than the argument passed in the constructor as a parameter for cfFileForNode(). Due to this w