Re: Code Review Request 7187876: ClassCastException in TCPTransport.executeAcceptLoop

2012-08-02 Thread Stuart Marks
Looks good. Pushed, http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a82e5f9c47f Please set the bug to Fix-Available in "beta" and add the "noreg-cleanup" keyword. s'marks On 8/2/12 2:14 PM, Darryl Mocek wrote: OK, not attachments allowed. Webrev can be found here: http://cr.openjdk.java.net/~dmo

Re: Code Review Request 7187876: ClassCastException in TCPTransport.executeAcceptLoop

2012-08-02 Thread Darryl Mocek
OK, not attachments allowed. Webrev can be found here: http://cr.openjdk.java.net/~dmocek/7187876/webrev.02 Darryl On Thu 02 Aug 2012 02:06:52 PM PDT, Darryl Mocek wrote: Let's try again... Darryl On Thu 02 Aug 2012 01:50:05 PM PDT, Darryl Mocek wrote: Patch attached using UndeclaredThr

Re: Code Review Request 7187876: ClassCastException in TCPTransport.executeAcceptLoop

2012-08-02 Thread Darryl Mocek
Let's try again... Darryl On Thu 02 Aug 2012 01:50:05 PM PDT, Darryl Mocek wrote: Patch attached using UndeclaredThrowableException. Darryl On Wed 01 Aug 2012 09:13:55 PM PDT, Stuart Marks wrote: On 8/1/12 8:05 PM, David Holmes wrote: This case is kind of pathological. The CloseServ

Re: Code Review Request 7187876: ClassCastException in TCPTransport.executeAcceptLoop

2012-08-02 Thread Darryl Mocek
Patch attached using UndeclaredThrowableException. Darryl On Wed 01 Aug 2012 09:13:55 PM PDT, Stuart Marks wrote: On 8/1/12 8:05 PM, David Holmes wrote: This case is kind of pathological. The CloseServerSocketOnTermination test injects an exception of an arbitrary type into the accept loop

Re: Code Review Request 7187876: ClassCastException in TCPTransport.executeAcceptLoop

2012-08-01 Thread Stuart Marks
On 8/1/12 8:05 PM, David Holmes wrote: This case is kind of pathological. The CloseServerSocketOnTermination test injects an exception of an arbitrary type into the accept loop of an RMI connection. (See the test to see how it does this; it's rather clever.) The cast error occurs when the excepti

Re: Code Review Request 7187876: ClassCastException in TCPTransport.executeAcceptLoop

2012-08-01 Thread David Holmes
Hi Stuart, On 2/08/2012 12:19 PM, Stuart Marks wrote: On 7/30/12 4:43 PM, David Holmes wrote: On 31/07/2012 8:27 AM, Darryl Mocek wrote: Hello core-libs. Please review this webrev to fix Bug #7187876. Webrev can be found here: http://cr.openjdk.java.net/~dmocek/7187876/webrev.00. The rmi/tran

Re: Code Review Request 7187876: ClassCastException in TCPTransport.executeAcceptLoop

2012-08-01 Thread Stuart Marks
On 7/30/12 4:43 PM, David Holmes wrote: On 31/07/2012 8:27 AM, Darryl Mocek wrote: Hello core-libs. Please review this webrev to fix Bug #7187876. Webrev can be found here: http://cr.openjdk.java.net/~dmocek/7187876/webrev.00. The rmi/transport/acceptLoop/CloseServerSocketOnTermination.java tes

Re: Code Review Request 7187876: ClassCastException in TCPTransport.executeAcceptLoop

2012-07-30 Thread David Holmes
Hi Darryl, On 31/07/2012 8:27 AM, Darryl Mocek wrote: Hello core-libs. Please review this webrev to fix Bug #7187876. Webrev can be found here: http://cr.openjdk.java.net/~dmocek/7187876/webrev.00. The rmi/transport/acceptLoop/CloseServerSocketOnTermination.java test throws ClassCastException d