Re: Convert old-style array declarations (was: Re: ByteArrayOutputStream should not have a new writeBytes method in Java)

2018-10-09 Thread Tagir Valeev
Hello! So the conversion was successfully performed for client components: https://bugs.openjdk.java.net/browse/JDK-8211300 http://hg.openjdk.java.net/jdk/client/rev/2e330da7cbf4 https://bugs.openjdk.java.net/browse/JDK-8211693 http://hg.openjdk.java.net/jdk/client/rev/de9486d74a74 Now we can mov

Re: Convert old-style array declarations

2018-10-02 Thread Stuart Marks
On 10/1/18 10:46 AM, Martin Buchholz wrote: This is one example of a change that should leave zero impact on the generated bytecode, and that should be testable, if only by comparing the .class files for identical size. This is a good point. I did something similar when I did the "diamond"

Re: Convert old-style array declarations (was: Re: ByteArrayOutputStream should not have a new writeBytes method in Java)

2018-10-01 Thread Martin Buchholz
Thank you very much for working on these cleanups. I've occasionally done similar in the past. I've made big changesets with only one automated change at a time. So e.g. I would do only "C-style array declaration" in one changeset. This is one example of a change that should leave zero impact on