Re: DateTimeFormatter.format() uses exceptions for flow control

2016-10-12 Thread Roger Riggs
Created an issue [1] and included the patch. Thanks, Roger [1] https://bugs.openjdk.java.net/browse/JDK-8167618 On 10/10/2016 2:53 AM, Clément MATHIEU wrote: On Mon, 2016-10-10 at 06:47 +1000, David Holmes wrote: Hi David, Please note that patches can only be accepted if they are sent

Re: DateTimeFormatter.format() uses exceptions for flow control

2016-10-10 Thread Clément MATHIEU
On Mon, 2016-10-10 at 06:47 +1000, David Holmes wrote: Hi David, > Please note that patches can only be accepted if they are sent > through, or hosted upon OpenJDK infrastructure. If the patch is small > enough can you send it inline in the email (attachments are often > stripped)  Here it is: 

Re: DateTimeFormatter.format() uses exceptions for flow control

2016-10-09 Thread Stephen Colebourne
This looks like it should be a worthwhile improvement. Stephen On 9 October 2016 at 16:24, Clément MATHIEU wrote: > Hi ! > > I noticed that DateTimePrintContext.getValue() relies on exceptions to > handle optionality. Using exceptions for flow control seems both >

Re: DateTimeFormatter.format() uses exceptions for flow control

2016-10-09 Thread David Holmes
Hi Clement, Please note that patches can only be accepted if they are sent through, or hosted upon OpenJDK infrastructure. If the patch is small enough can you send it inline in the email (attachments are often stripped) otherwise you will need to find an OpenJDK Author who can host the patch