Hi, Andrey.
On 27/01/2019 14:35, Andrey Turbanov wrote:
I checked only java.base module and fixed problems there. Does it
makes sense to create patches to other modules too?
You are welcome to make the similar changes in java.desktop module,
please use these email alias
No attachment received.
David
On 30/01/2019 8:02 am, Andrey Turbanov wrote:
Could you please re-generate your patch? The reason I'm asking is that the
current patch contains extra line breaks.
Hm. There wasn't any extra line breaks in sent email. Regenerated
patch attached.
Andre Turbanov
>Could you please re-generate your patch? The reason I'm asking is that the
>current patch contains extra line breaks.
Hm. There wasn't any extra line breaks in sent email. Regenerated
patch attached.
Andre Turbanov
fyi, mailers have a bad habit of wrapping patches at the wrong point.
Attaching it as a text (.txt) file works too.
On 01/29/2019 08:42 AM, Pavel Rappo wrote:
On 28 Jan 2019, at 22:23, Andrey Turbanov wrote:
Thanks to review. Patch updated. I'm not really sure what to do next.
I should find
> On 28 Jan 2019, at 22:23, Andrey Turbanov wrote:
>
> Thanks to review. Patch updated. I'm not really sure what to do next.
> I should find someone who can create issue and commit my patch to
> repository, right?
Andrey,
Could you please re-generate your patch? The reason I'm asking is that
On 29/01/2019 10:16 pm, Pavel Rappo wrote:
On 29 Jan 2019, at 08:50, David Holmes wrote:
Hi Pavel,
I don't think this kind of trivial change needs the OCA to be signed.
"A Participant may post messages to a list, submit simple patches, and make other
kinds of small contributions." [1]
Hi
> On 29 Jan 2019, at 08:50, David Holmes wrote:
>
> Hi Pavel,
>
> I don't think this kind of trivial change needs the OCA to be signed.
>
> "A Participant may post messages to a list, submit simple patches, and make
> other kinds of small contributions." [1]
Hi David,
That is true. However,
Hi Pavel,
On 29/01/2019 11:54 am, Pavel Rappo wrote:
On 28 Jan 2019, at 22:23, Andrey Turbanov wrote:
Thanks to review. Patch updated. I'm not really sure what to do next.
I should find someone who can create issue and commit my patch to
repository, right?
Have you signed the OCA [1]? The
> On 28 Jan 2019, at 22:23, Andrey Turbanov wrote:
>
> Thanks to review. Patch updated. I'm not really sure what to do next.
> I should find someone who can create issue and commit my patch to
> repository, right?
Have you signed the OCA [1]? The full process is described here [2].
If you have
> On 28/01/2019 17:04, Lance Andersen wrote:
> > The updates look fine
> >> - * This includes the case where a module reads another another with
> >> the
> >> + * This includes the case where a module reads another with the
> >>
> This one is typo, it should say "another module".
>
>
On 28/01/2019 17:04, Lance Andersen wrote:
The updates look fine
- * This includes the case where a module reads another another with the
+ * This includes the case where a module reads another with the
This one is typo, it should say "another module".
-Alan
The updates look fine
> On Jan 27, 2019, at 5:35 PM, Andrey Turbanov wrote:
>
> Hello.
> I noticed that Open JDK source code contains many duplicate words
> typos which could be easily find via simple regexp.
> I checked only java.base module and fixed problems there. Does it
> makes sense to
12 matches
Mail list logo
