Hi, Calvin
I have updated the webrev at
http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-02/
On 8/12/20 11:54 AM, calvin.che...@oracle.com wrote:
Hi Yumin,
I reviewed mostly the native code. Below are my comments:
1) classListParser.hpp
71 bool _lambda_format;
No
* File: InvokerBytecodeGeneratorHelper.java copyright header has GNU
without the "Classpath exception" clause.
* The comment could say this string prefix is known in hotspot
(classFileParser.cpp hard codes it)
+ // The log prefix for tracing resolve
+ static final String CDS_LOG_PREFIX = "@la
Hi Yumin,
I reviewed mostly the native code. Below are my comments:
1) classListParser.hpp
71 bool _lambda_format;
The above name is too generic. How about _lambda_form or _is_lambda_form?
If you rename the above, please also rename the function which returns
the above bool.
Hi Yumin,
This looks good!
Here are my comments:
[1] classListParser.cpp:
#define LAMBDA_FOMRM_INVOKER "@lambda-form-invoker"
I think this should be moved to classListParser.hpp:
const char* lambda_form_invoker_tag() {
return "@lambda-form-invoker";
}
Also, instead of also d
