Re: JDK-8011653: Upgrade to JAXP 1.5

2013-05-07 Thread huizhe wang
On 5/7/2013 12:49 AM, Alan Bateman wrote: On 07/05/2013 08:39, huizhe wang wrote: : : - DocumentBuilderFactory still says that SAXException is throw by DocumentBuilderFactory. Yes, that's what's in the jaxp1.3/1.4 spec unfortunately. Both DOM and SAX throws SAXException. It should have

Re: JDK-8011653: Upgrade to JAXP 1.5

2013-05-07 Thread Alan Bateman
On 07/05/2013 08:39, huizhe wang wrote: : : - DocumentBuilderFactory still says that SAXException is throw by DocumentBuilderFactory. Yes, that's what's in the jaxp1.3/1.4 spec unfortunately. Both DOM and SAX throws SAXException. It should have defined a DOMException for DOM operations.

Re: JDK-8011653: Upgrade to JAXP 1.5

2013-05-07 Thread huizhe wang
On 5/6/2013 11:46 PM, Alan Bateman wrote: On 06/05/2013 18:49, huizhe wang wrote: : True. I've added 176 new tests. JCK team is also testing using the current build of JAXP RI. I will also run regression tests. The new webrev included fixes to a couple of test failures in the last JPRT bui

Re: JDK-8011653: Upgrade to JAXP 1.5

2013-05-06 Thread Alan Bateman
On 06/05/2013 18:49, huizhe wang wrote: : True. I've added 176 new tests. JCK team is also testing using the current build of JAXP RI. I will also run regression tests. The new webrev included fixes to a couple of test failures in the last JPRT build. http://cr.openjdk.java.net/~joehw/jdk8

Re: JDK-8011653: Upgrade to JAXP 1.5

2013-05-06 Thread huizhe wang
On 5/4/2013 12:12 AM, Alan Bateman wrote: On 03/05/2013 19:02, huizhe wang wrote: : Removed the repetitive "value" definition from the setAttribute/setProperty methods. The open statements already have references to the properties in XMLConstants. Updated to: "The default value is implemen

Re: JDK-8011653: Upgrade to JAXP 1.5

2013-05-04 Thread Alan Bateman
On 03/05/2013 19:02, huizhe wang wrote: : Removed the repetitive "value" definition from the setAttribute/setProperty methods. The open statements already have references to the properties in XMLConstants. Updated to: "The default value is implementation specific and therefore not specified

Re: JDK-8011653: Upgrade to JAXP 1.5

2013-05-03 Thread huizhe wang
On 5/3/2013 7:49 AM, Alan Bateman wrote: On 03/05/2013 09:01, huizhe wang wrote: Hi Alan, Lance, This is an update that reflects the spec change, and also fixes for JDK-8013232 and JDK-8013484. Please review: http://cr.openjdk.java.net/~joehw/jdk8/8011653/webrev/ I've read through the jav

Re: JDK-8011653: Upgrade to JAXP 1.5

2013-05-03 Thread huizhe wang
On 5/3/2013 10:13 AM, Daniel Fuchs wrote: Hi Joe, I am not a JAXP expert - so I've been discovering most of this code as I read it. It would be impossible for me to assess whether there's some setFeature or setProperty missing somewhere for instance. So with my limited knowledge I have only the

Re: JDK-8011653: Upgrade to JAXP 1.5

2013-05-03 Thread Daniel Fuchs
Hi Joe, I am not a JAXP expert - so I've been discovering most of this code as I read it. It would be impossible for me to assess whether there's some setFeature or setProperty missing somewhere for instance. So with my limited knowledge I have only these few remarks: == 1. XalanConsta

Re: JDK-8011653: Upgrade to JAXP 1.5

2013-05-03 Thread Alan Bateman
On 03/05/2013 09:01, huizhe wang wrote: Hi Alan, Lance, This is an update that reflects the spec change, and also fixes for JDK-8013232 and JDK-8013484. Please review: http://cr.openjdk.java.net/~joehw/jdk8/8011653/webrev/ I've read through the javadoc/spec changes. One comment is that the

Re: JDK-8011653: Upgrade to JAXP 1.5

2013-05-03 Thread huizhe wang
Hi Alan, Lance, This is an update that reflects the spec change, and also fixes for JDK-8013232 and JDK-8013484. Please review: http://cr.openjdk.java.net/~joehw/jdk8/8011653/webrev/ Thanks, Joe On 4/18/2013 2:43 AM, huizhe wang wrote: On 4/15/2013 2:22 AM, Alan Bateman wrote: On 15/04/20

Re: JDK-8011653: Upgrade to JAXP 1.5

2013-04-18 Thread huizhe wang
On 4/15/2013 2:22 AM, Alan Bateman wrote: On 15/04/2013 08:48, Joe Wang wrote: : For the new properties then it specifies that a "a runtime exception" will be thrown. Can this be more specific? They can't be in XMLConstants, but they are in the specific Factories. The properties may be s

Re: JDK-8011653: Upgrade to JAXP 1.5

2013-04-15 Thread Alan Bateman
On 15/04/2013 08:48, Joe Wang wrote: : For the new properties then it specifies that a "a runtime exception" will be thrown. Can this be more specific? They can't be in XMLConstants, but they are in the specific Factories. The properties may be supported by factories that may throw differe

Re: JDK-8011653: Upgrade to JAXP 1.5

2013-04-15 Thread Joe Wang
On 4/8/2013 5:24 AM, Alan Bateman wrote: On 08/04/2013 08:39, huizhe wang wrote: Hi Lance, Alan, As I mentioned, I'd like to propose an integration of JAXP 1.5 into JDK8. JAXP 1.5 adds a new feature to control connections. Here's the webrev: http://cr.openjdk.java.net/~joehw/jdk8/8011653/w

Re: JDK-8011653: Upgrade to JAXP 1.5

2013-04-08 Thread Alan Bateman
On 08/04/2013 08:39, huizhe wang wrote: Hi Lance, Alan, As I mentioned, I'd like to propose an integration of JAXP 1.5 into JDK8. JAXP 1.5 adds a new feature to control connections. Here's the webrev: http://cr.openjdk.java.net/~joehw/jdk8/8011653/webrev/ Thanks, Joe I've done a first pass