Hi Pavel,
> As per [1] I'm updating this thread with yet another webrev:
>
> http://cr.openjdk.java.net/~prappo/8048267/webrev.05
Thanks and looks good.
Best regards,
Andrej Golovnin
As per [1] I'm updating this thread with yet another webrev:
http://cr.openjdk.java.net/~prappo/8048267/webrev.05
---
[1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-July/027487.html
-Pavel
On 30 Jun 2014, at 13:0
If a test run finishes fine, I'll push this version (no
Unsafe*LongFieldFieldAccessorImpl.java files included):
http://cr.openjdk.java.net/~prappo/8048267/webrev.04/
-Pavel
On 30 Jun 2014, at 11:31, Andrej Golovnin wrote:
> Hi Pavel,
>
> http://cr.openjdk.java.net/~prappo/8048267/webrev.03/s
Hi Pavel,
http://cr.openjdk.java.net/~prappo/8048267/webrev.03/src/share/classes/sun/reflect/UnsafeLongFieldAccessorImpl.java.sdiff.html
>
> http://cr.openjdk.java.net/~prappo/8048267/webrev.03/src/share/classes/sun/reflect/UnsafeQualifiedLongFieldAccessorImpl.java.sdiff.html
>
> http://cr.openjdk
I've updated the webrev. It includes all the changes we've discussed so far
plus these:
http://cr.openjdk.java.net/~prappo/8048267/webrev.03/src/macosx/classes/sun/font/CStrike.java.sdiff.html
http://cr.openjdk.java.net/~prappo/8048267/webrev.03/src/share/classes/com/sun/tools/example/debug/tty/B
Hi Otávio,
About Andrej, is it not possible add two people in "Contributed-by:" tag?
>
Thanks! But it's not needed. It's your contribution. I just help to review
the changes.
Best regards,
Andrej Golovnin
I found more two unnecessary valueOf.
About Andrej, is it not possible add two people in "Contributed-by:" tag?
diff -r d02b062bc827
src/share/classes/com/sun/tools/example/debug/tty/Commands.java
--- a/src/share/classes/com/sun/tools/example/debug/tty/Commands.java Fri
Jun 13 11:21:30 2014 -0700
Hi Pavel,
I'm not sure what the style guide for the source code says, but
there is a space between the cast operator and the field name in
src/share/classes/com/sun/jmx/snmp/daemon/SnmpAdaptorServer.java (line 881):
@Override
public Long getSnmpOutGenErrs() {
-return new Long(sn
I've just created a webrev with all the changes we've discussed so far. Plus
some more I've spotted while looking into the code. Please note, this webrev is
not incremental. It grabs all the changes between the original patch and the
latest discussed:
http://cr.openjdk.java.net/~prappo/8048267/
Hi Andrej,
They are not identical. Maybe it's just hard to spot it as it's not an
incremental webrev. Have a look at
(line 583):
http://cr.openjdk.java.net/~prappo/8048267/webrev.00/src/share/classes/javax/management/modelmbean/RequiredModelMBean.java.sdiff.html
http://cr.openjdk.java.net/~prap
Hi Pavel,
the both web revs looks identical to me. Here is what I have found so far
in the webrev.01:
in src/share/classes/com/sun/security/auth/SolarisNumericGroupPrincipal.java:
@@ -108,11 +108,11 @@
* @param primaryGroup true if the specified GID represents the
*
I created an issue to track the progress and also made 2 webrevs. One for the
original patch and one for the changes that have been suggested earlier in this
thread by Paul and Andrej. Here we go:
https://bugs.openjdk.java.net/browse/JDK-8048267
http://cr.openjdk.java.net/~prappo/8048267/webrev
On Jun 26, 2014, at 3:29 PM, Andrej Golovnin wrote:
> Hi Paul,
>
> Seems fine to me (pending a full test run).
>
> Just a syntax niggle in the following, too many brackets:
>
> +++ new/src/share/classes/javax/management/modelmbean/RequiredModelMBean.java
> 2014-06-14 10:16:02.486298421 -03
Hi Paul,
Seems fine to me (pending a full test run).
>
> Just a syntax niggle in the following, too many brackets:
>
> +++
> new/src/share/classes/javax/management/modelmbean/RequiredModelMBean.java
> 2014-06-14 10:16:02.486298421 -0300
> @@ -544,7 +544,7 @@
> }
>
> // co
On Jun 26, 2014, at 11:58 AM, Chris Hegarty wrote:
> Otavio,
>
> I skimmed over the patches and they look ok to me. I think they would be
> suitable for inclusion in jdk9/dev.
Seems fine to me (pending a full test run).
Just a syntax niggle in the following, too many brackets:
+++ new/src/
Thank you Chris.
I don't know if is better, but I did with all wrapper in this path.
http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-June/027285.html
But if will better, I can split each wrapper as path.
On Thu, Jun 26, 2014 at 6:58 AM, Chris Hegarty
wrote:
> Otavio,
>
> I skimmed ov
Otavio,
I skimmed over the patches and they look ok to me. I think they would be
suitable for inclusion in jdk9/dev.
-Chris.
P.S. I do not currently have time to sponsor this, but I cc’ed Pavel who may be
able to help get his in.
On 14 Jun 2014, at 14:46, Otávio Gonçalves de Santana
wrote:
Could anyone see my this path, please?
On Sat, Jun 14, 2014 at 10:46 AM, Otávio Gonçalves de Santana <
otavioj...@java.net> wrote:
> Reason: The Long class has cache and using it, will save memory and will
> faster than using create new instance of Long.
>
> webrev:
> https://dl.dropboxusercont
18 matches
Mail list logo
