Re: Optimization potential in Reader#read(CharBuffer)

2020-12-16 Thread Philippe Marschall
On Fri, Dec 11, 2020 at 5:35 PM Brian Burkhalter wrote: > > Hello, > > ... > > > I think perhaps they could all go in the same PR as the things are quite > related. It would be good to have simple JMH benchmarks to measure the > improvements. The benchmark code does not necessarily have to be in

Re: Optimization potential in Reader#read(CharBuffer)

2020-12-11 Thread Philippe Marschall
On Thu, Dec 10, 2020 at 9:25 PM Brian Burkhalter wrote: > > Hi Philippe, > > On Dec 10, 2020, at 12:03 PM, Philippe Marschall > wrote: > > ... > > > I think that core-libs-dev (CCed) would be more appropriate as java.io > package changes are usually discussed there. Thank you. > Do you have t

Re: Optimization potential in Reader#read(CharBuffer)

2020-12-11 Thread Philippe Marschall
Awesome, I'll work on a PR for this then. Cheers Philippe On Thu, Dec 10, 2020 at 10:04 PM Pavel Rappo wrote: > > I found this relevant issue created 17 years ago: > https://bugs.openjdk.java.net/browse/JDK-4926314 > > > On 10 Dec 2020, at 20:23, Brian Burkhalter > > wrote: > > > > Hi Philipp

Re: Optimization potential in Reader#read(CharBuffer)

2020-12-11 Thread Brian Burkhalter
Hello, > On Dec 11, 2020, at 8:31 AM, Philippe Marschall > wrote: > >> Do you have the ability to file an issue? If not, I can do so. > > I don't have the ability to file an issue. The bug that Pavel found is > enough for me to work on for now. If you believe pursuing two other > improvements

Re: Optimization potential in Reader#read(CharBuffer)

2020-12-10 Thread Brian Burkhalter
Awesome, Pavel, thanks! Brian > On Dec 10, 2020, at 1:02 PM, Pavel Rappo wrote: > > I found this relevant issue created 17 years ago: > https://bugs.openjdk.java.net/browse/JDK-4926314 > >> […] >> >> Do you have the ability to file an issue? If not, I can do so.

Re: Optimization potential in Reader#read(CharBuffer)

2020-12-10 Thread Pavel Rappo
I found this relevant issue created 17 years ago: https://bugs.openjdk.java.net/browse/JDK-4926314 > On 10 Dec 2020, at 20:23, Brian Burkhalter > wrote: > > Hi Philippe, > >> On Dec 10, 2020, at 12:03 PM, Philippe Marschall >> wrote: >> >> I recently came across Reader#read(CharBuffer) and

Re: Optimization potential in Reader#read(CharBuffer)

2020-12-10 Thread Brian Burkhalter
Hi Philippe, > On Dec 10, 2020, at 12:03 PM, Philippe Marschall > wrote: > > I recently came across Reader#read(CharBuffer) and noticed it was > missing an optimization for heap buffers. […] These seem like good suggestions. > Sorry if this is the wrong mailing list and should go to core-libs