Re: Pattern.splitAsStream JavaDoc doubt

2015-12-07 Thread Paul Sandoz
> On 7 Dec 2015, at 16:23, Tagir F. Valeev wrote: > > Hello, Chris, Paul! > > Thank you for the review. > >>> Tagir, >>> >>> It would seem most useful to update the implementation to >>> match the current spec. > > PS> Yes, it’s an oversight and lacked a test for such case. > > PS> Tagir, t

Re: Pattern.splitAsStream JavaDoc doubt

2015-12-07 Thread Tagir F. Valeev
Hello, Chris, Paul! Thank you for the review. >> Tagir, >> >> It would seem most useful to update the implementation to >> match the current spec. PS> Yes, it’s an oversight and lacked a test for such case. PS> Tagir, thanks for finding this. Would it be possible for you to PS> also add a test

Re: Pattern.splitAsStream JavaDoc doubt

2015-12-07 Thread Chris Hegarty
On 07/12/15 13:55, Paul Sandoz wrote: On 7 Dec 2015, at 11:18, Chris Hegarty wrote: Tagir, It would seem most useful to update the implementation to match the current spec. Yes, it’s an oversight and lacked a test for such case. Tagir, thanks for finding this. Would it be possible for you

Re: Pattern.splitAsStream JavaDoc doubt

2015-12-07 Thread Paul Sandoz
> On 7 Dec 2015, at 11:18, Chris Hegarty wrote: > > Tagir, > > It would seem most useful to update the implementation to > match the current spec. Yes, it’s an oversight and lacked a test for such case. Tagir, thanks for finding this. Would it be possible for you to also add a test to jdk/te

Re: Pattern.splitAsStream JavaDoc doubt

2015-12-07 Thread Chris Hegarty
Tagir, It would seem most useful to update the implementation to match the current spec. To that end, your first patch looks like the most appropriate change, pattern-patch.txt. -Chris. On 06/12/15 12:21, Tagir F. Valeev wrote: Hello! Currently Pattern.splitAsStream JavaDoc says [1]: * If