Re: Please Review java.time static interface methods move to supporting class

2013-10-02 Thread Stephen Colebourne
I would agree that methods work best here although we do use constants in other places (such as DTFormatter where it emphasises the immutability) I want to keep the Temporal prefix. Removing it from the static classes does shorten code, but no other pluralized helper class changes the name (eg. Co

Re: Please Review java.time static interface methods move to supporting class

2013-10-02 Thread roger riggs
Hi Sherman, Most of the new static factories in util and streams are methods. For example, that return interfaces (like Comparable). I think they are more clearly factories when defined as methods, even if they return a constant value. For consistency, I would retain them as methods and to allo

Re: Please Review java.time static interface methods move to supporting class

2013-10-02 Thread Xueming Shen
Hi, While it might make sense to have method to return the adjuster for TemporalAdjusters, is there any real benefit to have those parentheses for TemporalQueries? Maybe it can just be an enum? Or we are considering adding more parametrized adjusters in the future? Aren't we? Now all interfaces