Re: Please Review javadoc cleanup 8026516

2013-10-16 Thread roger riggs
Hi Lance, The immediate issue was to get javadoc -Xlint clean again. AFAIK that is what has been requested. Roger On 10/16/2013 4:56 PM, Lance Andersen - Oracle wrote: Hi Roger On Oct 16, 2013, at 4:50 PM, roger riggs wrote: Hi Lance, The empty tag is because in most cases it precedes a

Re: Please Review javadoc cleanup 8026516

2013-10-16 Thread Lance Andersen - Oracle
Hi Roger On Oct 16, 2013, at 4:50 PM, roger riggs wrote: > Hi Lance, > > The empty tag is because in most cases it precedes a or a header > . > So there is no content in the paragraph. I was referring more to an example such as this in Instant.java * Time-scale * * The length of the so

Re: Please Review javadoc cleanup 8026516

2013-10-16 Thread roger riggs
Hi Lance, The empty tag is because in most cases it precedes a or a header . So there is no content in the paragraph. In the past using an empty tag created some empty vertical space; but i understand that's a misuse of . I didn't try to compensate for that in my updates but it does change

Re: Please Review javadoc cleanup 8026516

2013-10-16 Thread Lance Andersen - Oracle
Hi Roger, I think what you have done is OK. I do have questions on should more be done in general so that we use (as I thought that was no required vs just a solo ?). As I started to look through some of the JDBC warnings, I saw more tags that I thought should have been reported by doclin

Re: Please Review javadoc cleanup 8026516

2013-10-16 Thread Joe Darcy
Hi Roger, Looks good; approved to go back. Thanks, -Joe On 10/16/2013 1:15 PM, roger riggs wrote: Hi, Javadoc cleanup to satisfy javadoc -Xlint. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-javadoc-8026516/ Thanks, Roger

Re: Please Review javadoc cleanup 8026516

2013-10-16 Thread Mike Duigou
Looks fine. To make things easier I reviewed the patch rather than the individual file diffs. Mike On Oct 16 2013, at 13:15 , roger riggs wrote: > Hi, > > Javadoc cleanup to satisfy javadoc -Xlint. > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-javadoc-8026516/ > > Thanks, Roger