RE: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-05-07 Thread Lindenmaier, Goetz
; >> From: Simon Nash [mailto:si...@cjnash.com] > >> Sent: Dienstag, 24. April 2018 18:17 > >> To: Lindenmaier, Goetz > >> Cc: David Holmes ; hotspot-runtime- > >> d...@openjdk.java.net; hotspot-compiler-...@openjdk.java.net; > aarch64- > >> port-..

Re: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-05-04 Thread David Holmes
.@cjnash.com] Sent: Dienstag, 24. April 2018 18:17 To: Lindenmaier, Goetz Cc: David Holmes ; hotspot-runtime- d...@openjdk.java.net; hotspot-compiler-...@openjdk.java.net; aarch64- port-...@openjdk.java.net; aarch32-port-...@openjdk.java.net; core-libs- dev Libs Subject: Re: RFR(M): 8201593: Print a

Re: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-05-04 Thread Roger Riggs
maier, Goetz ; hotspot-runtime- d...@openjdk.java.net; hotspot-compiler-...@openjdk.java.net; aarch64- port-...@openjdk.java.net; aarch32-port-...@openjdk.java.net; core- libs- dev Libs Subject: Re: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException. Hi Goetz, This is not a f

Re: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-04-24 Thread Simon Nash
olmes [mailto:david.hol...@oracle.com] Sent: Mittwoch, 18. April 2018 10:55 To: Lindenmaier, Goetz ; hotspot-runtime- d...@openjdk.java.net; hotspot-compiler-...@openjdk.java.net; aarch64- port-...@openjdk.java.net; aarch32-port-...@openjdk.java.net; core- libs- dev Libs Subject: Re: RFR

RE: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-04-24 Thread Lindenmaier, Goetz
; > > I'll push it through our tests tonight. > > > > See further comments in line: > > > >> -Original Message- > >> From: David Holmes [mailto:david.hol...@oracle.com] > >> Sent: Freitag, 20. April 2018 09:25 > >> To: Lindenmaier, G

RE: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-04-24 Thread Lindenmaier, Goetz
itag, 20. April 2018 09:25 > To: Lindenmaier, Goetz ; hotspot-runtime- > d...@openjdk.java.net; hotspot-compiler-...@openjdk.java.net; aarch64- > port-...@openjdk.java.net; aarch32-port-...@openjdk.java.net; core-libs- > dev Libs > Subject: Re: RFR(M): 8201593: Print array length in > Array

Re: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-04-23 Thread Simon Nash
10:55 To: Lindenmaier, Goetz ; hotspot-runtime- d...@openjdk.java.net; hotspot-compiler-...@openjdk.java.net; aarch64- port-...@openjdk.java.net; aarch32-port-...@openjdk.java.net; core- libs- dev Libs Subject: Re: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

Re: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-04-23 Thread David Holmes
25 To: Lindenmaier, Goetz ; hotspot-runtime- d...@openjdk.java.net; hotspot-compiler-...@openjdk.java.net; aarch64- port-...@openjdk.java.net; aarch32-port-...@openjdk.java.net; core- libs- dev Libs Subject: Re: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException. Hi Goet

RE: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-04-23 Thread Lindenmaier, Goetz
lto:david.hol...@oracle.com] > >> Sent: Freitag, 20. April 2018 09:25 > >> To: Lindenmaier, Goetz ; hotspot-runtime- > >> d...@openjdk.java.net; hotspot-compiler-...@openjdk.java.net; > aarch64- > >> port-...@openjdk.java.net; aarch32-port-...@openjdk.java.net; co

RE: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-04-23 Thread Lindenmaier, Goetz
gt; Thanks, > >Goetz. > > > > > >> -Original Message- > >> From: David Holmes [mailto:david.hol...@oracle.com] > >> Sent: Freitag, 20. April 2018 09:25 > >> To: Lindenmaier, Goetz ; hotspot-runtime- > >> d...@openjdk.java.net; hots

Re: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-04-22 Thread David Holmes
penjdk.java.net; aarch64- port-...@openjdk.java.net; aarch32-port-...@openjdk.java.net; core-libs- dev Libs Subject: Re: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException. Hi Goetz, This is not a file by file review ... On 19/04/2018 10:24 PM, Lindenmaier, Goetz wrote: Hi, New webr

RE: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-04-20 Thread Lindenmaier, Goetz
; To: Lindenmaier, Goetz ; hotspot-runtime- > d...@openjdk.java.net; hotspot-compiler-...@openjdk.java.net; aarch64- > port-...@openjdk.java.net; aarch32-port-...@openjdk.java.net; core-libs- > dev Libs > Subject: Re: RFR(M): 8201593: Print array length in > ArrayIndexOutOfBoundsExcept

Re: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-04-20 Thread David Holmes
length 10. Negative range -19 when copying from an object array of length 10 to an object array of length 5. Best regards, Goetz. -Original Message- From: David Holmes [mailto:david.hol...@oracle.com] Sent: Mittwoch, 18. April 2018 10:55 To: Lindenmaier, Goetz ; hotspot-runtime- d...@

RE: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-04-19 Thread Lindenmaier, Goetz
mes ; core-libs- > d...@openjdk.java.net; hotspot-runtime-...@openjdk.java.net > Subject: Re: RFR(M): 8201593: Print array length in > ArrayIndexOutOfBoundsException. > > Hi David, > > A private constructor that is apparently unused (because it is used > implicitly by code

Re: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-04-19 Thread Roger Riggs
Hi David, A private constructor that is apparently unused (because it is used implicitly by code buried in HotSpot) is going to raise questions. Strictly speaking the new constructor is not necessary since the native code can compose the full message and use the existing constructor. I'd rec

Re: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-04-19 Thread Andrew Haley
On 04/18/2018 03:30 PM, Roger Riggs wrote: > Which roughly reads as: > > Index %d out-of-bounds for length %d "out-of-bounds" shouldn't be hyphenated because it's not a compound adjective. Besides that, it's unnecessary because you already know its an ArrayIndexOutOfBoundsException. I

RE: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-04-19 Thread Lindenmaier, Goetz
2018 10:55 > To: Lindenmaier, Goetz ; hotspot-runtime- > d...@openjdk.java.net; hotspot-compiler-...@openjdk.java.net; aarch64- > port-...@openjdk.java.net; aarch32-port-...@openjdk.java.net; core-libs- > dev Libs > Subject: Re: RFR(M): 8201593: Print array length in > ArrayIndexOutOfBoundsException

Re: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-04-18 Thread David Holmes
Adding back hotspot-runtime-dev - please reply-all On 19/04/2018 1:26 AM, Roger Riggs wrote: Hi, Also, the new constructor should be public so it can be used in other places. That takes this from being a simple change that adds more info to the exception message, to an API addition that re

Re: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-04-18 Thread Roger Riggs
Hi, Also, the new constructor should be public so it can be used in other places. It seems in some cases the error message is a literal in the VM code ( typeArrayKlass.cpp:149). That would seem to be a duplication and not really a good idea. Roger On 4/18/18 10:30 AM, Roger Riggs wrote:

Re: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-04-18 Thread Roger Riggs
Hi, The message can be simpler and more efficiently convey the information. It should be more consistent with existing uses of ArrayIndexOutOfBoundsException as throw by:  Objects.checkIndex(index, length). Which roughly reads as: Index %d out-of-bounds for length %d Regards, Roger On 4/

Re: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-04-18 Thread David Holmes
Adding core-libs-dev as you're changing java.lang.ArrayIndexOutOfBoundsException. I appreciate the intent here but I find the messages excessively verbose. The basic error is: index N is outside range [0, length-1] David On 18/04/2018 6:09 PM, Lindenmaier, Goetz wrote: Hi, I would like to