; >> From: Simon Nash [mailto:si...@cjnash.com]
> >> Sent: Dienstag, 24. April 2018 18:17
> >> To: Lindenmaier, Goetz
> >> Cc: David Holmes ; hotspot-runtime-
> >> d...@openjdk.java.net; hotspot-compiler-...@openjdk.java.net;
> aarch64-
> >> port-..
.@cjnash.com]
Sent: Dienstag, 24. April 2018 18:17
To: Lindenmaier, Goetz
Cc: David Holmes ; hotspot-runtime-
d...@openjdk.java.net; hotspot-compiler-...@openjdk.java.net; aarch64-
port-...@openjdk.java.net; aarch32-port-...@openjdk.java.net; core-libs-
dev Libs
Subject: Re: RFR(M): 8201593: Print a
maier, Goetz ; hotspot-runtime-
d...@openjdk.java.net; hotspot-compiler-...@openjdk.java.net;
aarch64-
port-...@openjdk.java.net; aarch32-port-...@openjdk.java.net; core-
libs-
dev Libs
Subject: Re: RFR(M): 8201593: Print array length in
ArrayIndexOutOfBoundsException.
Hi Goetz,
This is not a f
olmes [mailto:david.hol...@oracle.com]
Sent: Mittwoch, 18. April 2018 10:55
To: Lindenmaier, Goetz ; hotspot-runtime-
d...@openjdk.java.net; hotspot-compiler-...@openjdk.java.net;
aarch64-
port-...@openjdk.java.net; aarch32-port-...@openjdk.java.net; core-
libs-
dev Libs
Subject: Re: RFR
;
> > I'll push it through our tests tonight.
> >
> > See further comments in line:
> >
> >> -Original Message-
> >> From: David Holmes [mailto:david.hol...@oracle.com]
> >> Sent: Freitag, 20. April 2018 09:25
> >> To: Lindenmaier, G
itag, 20. April 2018 09:25
> To: Lindenmaier, Goetz ; hotspot-runtime-
> d...@openjdk.java.net; hotspot-compiler-...@openjdk.java.net; aarch64-
> port-...@openjdk.java.net; aarch32-port-...@openjdk.java.net; core-libs-
> dev Libs
> Subject: Re: RFR(M): 8201593: Print array length in
> Array
10:55
To: Lindenmaier, Goetz ; hotspot-runtime-
d...@openjdk.java.net; hotspot-compiler-...@openjdk.java.net;
aarch64-
port-...@openjdk.java.net; aarch32-port-...@openjdk.java.net; core-
libs-
dev Libs
Subject: Re: RFR(M): 8201593: Print array length in
ArrayIndexOutOfBoundsException.
25
To: Lindenmaier, Goetz ; hotspot-runtime-
d...@openjdk.java.net; hotspot-compiler-...@openjdk.java.net;
aarch64-
port-...@openjdk.java.net; aarch32-port-...@openjdk.java.net; core-
libs-
dev Libs
Subject: Re: RFR(M): 8201593: Print array length in
ArrayIndexOutOfBoundsException.
Hi Goet
lto:david.hol...@oracle.com]
> >> Sent: Freitag, 20. April 2018 09:25
> >> To: Lindenmaier, Goetz ; hotspot-runtime-
> >> d...@openjdk.java.net; hotspot-compiler-...@openjdk.java.net;
> aarch64-
> >> port-...@openjdk.java.net; aarch32-port-...@openjdk.java.net; co
gt; Thanks,
> >Goetz.
> >
> >
> >> -Original Message-
> >> From: David Holmes [mailto:david.hol...@oracle.com]
> >> Sent: Freitag, 20. April 2018 09:25
> >> To: Lindenmaier, Goetz ; hotspot-runtime-
> >> d...@openjdk.java.net; hots
penjdk.java.net; aarch64-
port-...@openjdk.java.net; aarch32-port-...@openjdk.java.net; core-libs-
dev Libs
Subject: Re: RFR(M): 8201593: Print array length in
ArrayIndexOutOfBoundsException.
Hi Goetz,
This is not a file by file review ...
On 19/04/2018 10:24 PM, Lindenmaier, Goetz wrote:
Hi,
New webr
; To: Lindenmaier, Goetz ; hotspot-runtime-
> d...@openjdk.java.net; hotspot-compiler-...@openjdk.java.net; aarch64-
> port-...@openjdk.java.net; aarch32-port-...@openjdk.java.net; core-libs-
> dev Libs
> Subject: Re: RFR(M): 8201593: Print array length in
> ArrayIndexOutOfBoundsExcept
length 10.
Negative range -19 when copying from an object array of length 10 to an object
array of length 5.
Best regards,
Goetz.
-Original Message-
From: David Holmes [mailto:david.hol...@oracle.com]
Sent: Mittwoch, 18. April 2018 10:55
To: Lindenmaier, Goetz ; hotspot-runtime-
d...@
mes ; core-libs-
> d...@openjdk.java.net; hotspot-runtime-...@openjdk.java.net
> Subject: Re: RFR(M): 8201593: Print array length in
> ArrayIndexOutOfBoundsException.
>
> Hi David,
>
> A private constructor that is apparently unused (because it is used
> implicitly by code
Hi David,
A private constructor that is apparently unused (because it is used
implicitly by code
buried in HotSpot) is going to raise questions.
Strictly speaking the new constructor is not necessary since the native
code can
compose the full message and use the existing constructor.
I'd rec
On 04/18/2018 03:30 PM, Roger Riggs wrote:
> Which roughly reads as:
>
> Index %d out-of-bounds for length %d
"out-of-bounds" shouldn't be hyphenated because it's not a compound
adjective. Besides that, it's unnecessary because you already know
its an ArrayIndexOutOfBoundsException.
I
2018 10:55
> To: Lindenmaier, Goetz ; hotspot-runtime-
> d...@openjdk.java.net; hotspot-compiler-...@openjdk.java.net; aarch64-
> port-...@openjdk.java.net; aarch32-port-...@openjdk.java.net; core-libs-
> dev Libs
> Subject: Re: RFR(M): 8201593: Print array length in
> ArrayIndexOutOfBoundsException
Adding back hotspot-runtime-dev - please reply-all
On 19/04/2018 1:26 AM, Roger Riggs wrote:
Hi,
Also, the new constructor should be public so it can be used in other
places.
That takes this from being a simple change that adds more info to the
exception message, to an API addition that re
Hi,
Also, the new constructor should be public so it can be used in other
places.
It seems in some cases the error message is a literal in the VM code (
typeArrayKlass.cpp:149).
That would seem to be a duplication and not really a good idea.
Roger
On 4/18/18 10:30 AM, Roger Riggs wrote:
Hi,
The message can be simpler and more efficiently convey the information.
It should be more consistent with existing uses of
ArrayIndexOutOfBoundsException as
throw by: Objects.checkIndex(index, length).
Which roughly reads as:
Index %d out-of-bounds for length %d
Regards, Roger
On 4/
Adding core-libs-dev as you're changing
java.lang.ArrayIndexOutOfBoundsException.
I appreciate the intent here but I find the messages excessively
verbose. The basic error is:
index N is outside range [0, length-1]
David
On 18/04/2018 6:09 PM, Lindenmaier, Goetz wrote:
Hi,
I would like to
21 matches
Mail list logo