Hi,
I've reworked this patch after recent parseInt API updates (8055251) and
removed the test additions which are being covered by 8057826.
I also discovered a missed opportunity to apply the same optimization to
java.sql.Date which I missed earlier:
http://cr.openjdk.java.net/~redestad/805
On 2014-09-04 21:20, Lance Andersen wrote:
Hi Claes,
I am assuming the changes to the Time and Timestamp have not changed,
you just moved them to the new structure.
Yes, unchanged otherwise.
WRT the tests, I actually want to add more value testing. I am in the
process of updating Time a
Hi Claes,
I am assuming the changes to the Time and Timestamp have not changed, you just
moved them to the new structure.
WRT the tests, I actually want to add more value testing. I am in the process
of updating Time and Timestamp tests to use a DataProvider. Once I finish
this, I will send
Hi,
I took the liberty to shuffle around the patch to the new structure
and add a few tests, particularly testing subtly different invalid
formats and better exercising the logic around Timestamp nanos (tested
using both old and new code):
http://cr.openjdk.java.net/~redestad/8055055/webre
I think this is OK. However, I want to write some additional tests to reduce
the chance of regression and add this as part of the putback
I am going to be out of the office for a few days so doubt I will get to this
for another week or so
Best,
Lance
On Aug 13, 2014, at 3:42 PM, Claes Redestad
Thanks, Lance!
I only ran the jtreg tests under jdk/test/java/sql locally for this (29
passed).
/Claes
On 2014-08-13 20:14, Lance Andersen wrote:
I will take a look this week. Did you run the unit tests to make sure
they still pass?
On Aug 13, 2014, at 12:49 PM, Claes Redestad
mailto:cl
I will take a look this week. Did you run the unit tests to make sure they
still pass?
On Aug 13, 2014, at 12:49 PM, Claes Redestad wrote:
> Hi,
>
> can I have a review of this small patch which improves performance of
> java.sql.Time::valueOf (~1.3x) and java.sql.Timestamp::valueOf (~1.9x)
