On Tue, 15 Sep 2020 16:59:59 GMT, Lance Andersen wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove "final"
>
> I am fine with this as well. I will pull over the change and just sanity
> check it via mach5
On Tue, 15 Sep 2020 15:45:05 GMT, Jaikiran Pai wrote:
> As for this:
>
>> As long as the input stream close() method is idem potent this should be
>> safe, and AFAICS that is the case for the two
>> input stream subclasses that can be returned by ZipFile::getInputStream.
>
> I'm curious, in
On Tue, 15 Sep 2020 15:45:05 GMT, Jaikiran Pai wrote:
> I'm curious, in the context of this change, why idempotency would be a
> necessity. Would there be a "double close"
> somehow on this `InputStream` instance?
My bad - I hadn't realised closing the input stream would also remove it from
On Tue, 15 Sep 2020 15:33:51 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove "final"
>
> Hi Jaikiran,
>
> This is not an area I know too well - so I won't review formally, but the
>
On Tue, 15 Sep 2020 15:29:44 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove "final"
>
> src/java.base/share/classes/java/util/jar/JarFile.java line 428:
>
>> 426: try
