Hi Brent,
Ok I tested on Windows with JA installed and your patch works,
also tested on Solaris.
On other nit, Copyright on I18NJarTest.java needs updating.
Looks good, go for it.
Thanks
Kumar
On 2/21/13 7:33 PM, Kumar Srinivasan wrote:
A nit
- LC_ALL + LC_ALL + \n +
+ LC_ALL= +
On 2/22/13 10:22 AM, Naoto Sato wrote:
check not only C but also other locales that do not use UTF-8
encoding.
I would like to make the test more robust (per 8008761), though my focus
at the moment is to avoid a test failure on our automated test systems,
which all use C.
I've made a note
Looks good. Thank you for fixing this.
Naoto
On 2/25/13 10:53 AM, Brent Christian wrote:
On 2/22/13 10:22 AM, Naoto Sato wrote:
check not only C but also other locales that do not use UTF-8
encoding.
I would like to make the test more robust (per 8008761), though my focus
at the moment is
couple of minor nits I did not see in rev 01.
Copyright,
-if(C.equals(LC_ALL) || C.equals(LANG)) {
+if (C.equals(LC_ALL) || C.equals(LANG)) {
Kumar
Looks good. Thank you for fixing this.
Naoto
On 2/25/13 10:53 AM, Brent Christian wrote:
On 2/22/13 10:22 AM, Naoto Sato
Thanks for the review, guys.
Think I've got it all in:
http://cr.openjdk.java.net/~bchristi/8006039/webrev.02/
For the Copyright, do I just need to change the year(s) to 2012, 2013,?
Also, thanks a lot for running the Windows testing, Kumar.
Can someone push this for me? I can send a patch
I can take care of it.
Kumar
Thanks for the review, guys.
Think I've got it all in:
http://cr.openjdk.java.net/~bchristi/8006039/webrev.02/
For the Copyright, do I just need to change the year(s) to 2012, 2013,?
Also, thanks a lot for running the Windows testing, Kumar.
Can someone push
Hi Brent,
I think the condition needs to check if it is on Unix environment, and
check not only C but also other locales that do not use UTF-8
encoding. Also, LC_ALL precedes LANG environment variable, so I'd
check LC_ALL first, and if it is not exported then check LANG variable.
Naoto
On
On 2/21/13 7:33 PM, Kumar Srinivasan wrote:
A nit
- LC_ALL + LC_ALL + \n +
+ LC_ALL= + LC_ALL + \n +
Done, thanks.
If Mac is the only system affected by this, should we make the checks for
LC* and LANG specific to Macs since other platforms don't have this issue ?
I am concerned this
Hi Brent,
I am not an expert here, and I am hoping someone from I18N
also reviews this.
A nit
- LC_ALL + LC_ALL + \n +
+ LC_ALL= + LC_ALL + \n +
If Mac is the only system affected by this, should we make the checks for
LC* and LANG specific to Macs since other platforms don't have this
