On 07/01/2013 02:52 AM, Remi Forax wrote:
> On 06/29/2013 02:58 AM, Henry Jen wrote:
>> Hi,
>>
>> Please review the webrev that add concat static method to Stream and
>> primitive Streams.
>>
>> http://cr.openjdk.java.net/~henryjen/ccc/8015315.0/webrev/
>>
>> Cheers,
>> Henry
>
> Hi Henry,
> I fin
On Jul 3, 2013, at 11:18 AM, Peter Levart wrote:
> Hi Henry,
>
> I think that ConcatSpliterator.characteristics() method is not honoring
> the spec which says:
>
> * Returns a set of characteristics of this Spliterator and its
> * elements. The result is represented as ORed values f
Hi Henry,
I think that ConcatSpliterator.characteristics() method is not honoring
the spec which says:
* Returns a set of characteristics of this Spliterator and its
* elements. The result is represented as ORed values from {@link
* #ORDERED}, {@link #DISTINCT}, {@link #SORTED},
Hi,
Perhaps the Spliterator.trySplit() method should have been declared as:
Spliterator trySplit();
Regards, Peter
On 07/01/2013 05:50 PM, Peter Levart wrote:
On 07/01/2013 03:19 PM, Remi Forax wrote:
On 07/01/2013 01:36 PM, Peter Levart wrote:
On 07/01/2013 11:52 AM, Remi Forax wrote:
On 07/01/2013 03:19 PM, Remi Forax wrote:
On 07/01/2013 01:36 PM, Peter Levart wrote:
On 07/01/2013 11:52 AM, Remi Forax wrote:
On 06/29/2013 02:58 AM, Henry Jen wrote:
Hi,
Please review the webrev that add concat static method to Stream and
primitive Streams.
http://cr.openjdk.java.net/~h
On 07/01/2013 01:36 PM, Peter Levart wrote:
On 07/01/2013 11:52 AM, Remi Forax wrote:
On 06/29/2013 02:58 AM, Henry Jen wrote:
Hi,
Please review the webrev that add concat static method to Stream and
primitive Streams.
http://cr.openjdk.java.net/~henryjen/ccc/8015315.0/webrev/
Cheers,
Henry
On 07/01/2013 11:52 AM, Remi Forax wrote:
On 06/29/2013 02:58 AM, Henry Jen wrote:
Hi,
Please review the webrev that add concat static method to Stream and
primitive Streams.
http://cr.openjdk.java.net/~henryjen/ccc/8015315.0/webrev/
Cheers,
Henry
Hi Henry,
I find the the cast to Spliterat
On 06/29/2013 02:58 AM, Henry Jen wrote:
Hi,
Please review the webrev that add concat static method to Stream and
primitive Streams.
http://cr.openjdk.java.net/~henryjen/ccc/8015315.0/webrev/
Cheers,
Henry
Hi Henry,
I find the the cast to Spliterator in Streams.concat() dubious,
I can not se
Hi Henry,
On Jun 29, 2013, at 2:58 AM, Henry Jen wrote:
> Hi,
>
> Please review the webrev that add concat static method to Stream and
> primitive Streams.
>
> http://cr.openjdk.java.net/~henryjen/ccc/8015315.0/webrev/
>
Non test-code looks good.
Now that LongStream.range uses concat you ne
