RE: RFR: 8144062: Move jdk.Version to java.lang.Runtime.Version

2016-05-19 Thread Iris Clark
Hi, Mandy. Thank you so much for pushing the changesets [0,1] for this bug. Regards, Iris [0]: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/3976fadb091d [1]: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/2a49d47a37d8

RE: RFR: 8144062: Move jdk.Version to java.lang.Runtime.Version

2016-05-18 Thread Iris Clark
Hi, Mandy. Thanks for taking the time to Review. >>http://cr.openjdk.java.net/~iris/verona/8144062/webrev.1/ > The change looks fine. Minor comments: > > 1178 * @throws IllegalArgumentException > 1179 * If the given string cannot be interpreted as a valid > 1180

RE: RFR: 8144062: Move jdk.Version to java.lang.Runtime.Version

2016-05-18 Thread Iris Clark
Hi, Jon. >> http://cr.openjdk.java.net/~iris/verona/8144062/webrev.1/ > Langtools changes are OK, including the indirect use of the revised > Version in jar-fs. Thanks for the Review. Regards, Iris

Re: RFR: 8144062: Move jdk.Version to java.lang.Runtime.Version

2016-05-18 Thread Jonathan Gibbons
Langtools changes are OK, including the indirect use of the revised Version in jar-fs. -- Jon On 05/13/2016 04:20 PM, Iris Clark wrote: Hi. Reviving this work from a few months back. Please review the following changes to move jdk.Version to jdk.lang.Runtime.Version. Bug 8144062: Move

Re: RFR: 8144062: Move jdk.Version to java.lang.Runtime.Version

2016-05-18 Thread Mandy Chung
> On May 13, 2016, at 4:20 PM, Iris Clark wrote: > > Hi. > > Reviving this work from a few months back. > > Please review the following changes to move jdk.Version to > jdk.lang.Runtime.Version. > > Bug > >8144062: Move jdk.Version to java.lang.Runtime.Version >https://bugs.openjdk.

Re: RFR: 8144062: Move jdk.Version to java.lang.Runtime.Version

2016-05-16 Thread forax
- Mail original - > De: "Iris Clark" > À: "Remi Forax" > Cc: "Java Core Libs" , > compiler-...@openjdk.java.net, verona-...@openjdk.java.net > Envoyé: Lundi 16 Mai 2016 19:52:33 > Objet: RE: RFR: 8144062: Move jdk.Version to j

RE: RFR: 8144062: Move jdk.Version to java.lang.Runtime.Version

2016-05-16 Thread Iris Clark
62-jar 2154 8600 171312 total -Original Message- From: Remi Forax [mailto:fo...@univ-mlv.fr] Sent: Friday, May 13, 2016 4:32 PM To: Iris Clark Cc: Java Core Libs; compiler-...@openjdk.java.net; verona-...@openjdk.java.net Subject: Re: RFR: 8144062: Move jdk.Version to java.lang.Runtime.Ve

Re: RFR: 8144062: Move jdk.Version to java.lang.Runtime.Version

2016-05-13 Thread Remi Forax
Hi Iris, is there a way to avoid to use regex when parsing the version ? java.lang.Runtime.Version is used during the boot process, so now every Java programs loads a bunch of classes related to java.util.regex even if they do not use any regex or use another regex engine (like Nashorn or JRuby)