Re: RFR: 8161379: Force inline methods calling Reflection.getCallerClass

2016-08-05 Thread Claes Redestad
Thanks! Up to 12-15x on some reflection micros, but it varies wildly. This change does not improve the best case performance, but rather eliminates a cause for degradation and high run to run variance. /Claes Mandy Chung skrev: (5 augusti 2016 14:55:59 GMT-07:00) > >> On Aug 5, 2016, at 1:22

Re: RFR: 8161379: Force inline methods calling Reflection.getCallerClass

2016-08-05 Thread Mandy Chung
> On Aug 5, 2016, at 1:22 PM, Claes Redestad wrote: > > http://cr.openjdk.java.net/~redestad/8161379/jdk.02/ > Looks fine. How much improvement do you see from the benchmark run with this patch? Mandy

Re: RFR: 8161379: Force inline methods calling Reflection.getCallerClass

2016-08-05 Thread Aleksey Shipilev
On 08/05/2016 11:22 PM, Claes Redestad wrote: > On 08/05/2016 12:56 PM, Aleksey Shipilev wrote: >> I wouldn't mind to have a comment at @ForceInline line mentioning this >> is for Reflection.getCallerClass() optimization. But, it might be >> recoverable from the source control anyway. > > Sure, ho

Re: RFR: 8161379: Force inline methods calling Reflection.getCallerClass

2016-08-05 Thread Claes Redestad
On 08/05/2016 12:56 PM, Aleksey Shipilev wrote: This looks good to me, Claes. Thanks! I wouldn't mind to have a comment at @ForceInline line mentioning this is for Reflection.getCallerClass() optimization. But, it might be recoverable from the source control anyway. Sure, how about: @Forc

Re: RFR: 8161379: Force inline methods calling Reflection.getCallerClass

2016-08-05 Thread Aleksey Shipilev
This looks good to me, Claes. I wouldn't mind to have a comment at @ForceInline line mentioning this is for Reflection.getCallerClass() optimization. But, it might be recoverable from the source control anyway. Thanks, -Aleksey On 08/05/2016 10:37 PM, Claes Redestad wrote: > Anyone? > > On 07/1

Re: RFR: 8161379: Force inline methods calling Reflection.getCallerClass

2016-08-05 Thread Claes Redestad
Anyone? On 07/19/2016 08:16 AM, Claes Redestad wrote: Hi, most @CallerSensitive methodscall Reflection.getCallerClass(), which turn out to have problematic performance characteristics when it fails to inline. Making @CallerSensitive imply @ForceInline actually works rather well across benchmar