On Sat, 5 Jun 2021 00:15:25 GMT, Dan Smith wrote:
>> Standardizes and better specifies the errors thrown by LambdaMetafactory,
>> including for inputs that would not be generated by javac.
>>
>> Does some renaming of core parameters/fields to better reflect their purpose.
>>
>> In the implemen
On Fri, 4 Jun 2021 23:41:06 GMT, Dan Smith wrote:
>> src/java.base/share/classes/java/lang/invoke/LambdaMetafactory.java line 312:
>>
>>> 310: * @return a CallSite whose target can be used to perform capture,
>>> generating
>>> 311: * instances of the interface named by {@code
> Standardizes and better specifies the errors thrown by LambdaMetafactory,
> including for inputs that would not be generated by javac.
>
> Does some renaming of core parameters/fields to better reflect their purpose.
>
> In the implementation, stops using ACC_BRIDGE for any methods, which is n
On Fri, 4 Jun 2021 22:09:39 GMT, Mandy Chung wrote:
> Can you also rename the parameter names in
> `java.lang.invoke.LambdaProxyClassArchive` methods to match the new ones?
Hmm, that expands the reach of the patch a bit—into native HotSpot code—but
I've given it a try. Let me know if it looks
On Fri, 4 Jun 2021 22:06:49 GMT, Mandy Chung wrote:
>> Dan Smith has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address reviewer comments
>
> src/java.base/share/classes/java/lang/invoke/LambdaMetafactory.java line 312:
>
>> 310:
On Fri, 4 Jun 2021 22:04:19 GMT, Dan Smith wrote:
>> Standardizes and better specifies the errors thrown by LambdaMetafactory,
>> including for inputs that would not be generated by javac.
>>
>> Does some renaming of core parameters/fields to better reflect their purpose.
>>
>> In the implemen
On Fri, 4 Jun 2021 06:16:45 GMT, Peter Levart wrote:
>> Dan Smith has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix accidentally commented-out parts of test
>
> src/java.base/share/classes/java/lang/invoke/AbstractValidatingLambdaMetaf
> Standardizes and better specifies the errors thrown by LambdaMetafactory,
> including for inputs that would not be generated by javac.
>
> Does some renaming of core parameters/fields to better reflect their purpose.
>
> In the implementation, stops using ACC_BRIDGE for any methods, which is n
On Fri, 4 Jun 2021 01:22:05 GMT, liach
wrote:
>> Dan Smith has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix accidentally commented-out parts of test
>
> src/java.base/share/classes/java/lang/invoke/LambdaMetafactory.java line 547:
>
On Fri, 4 Jun 2021 00:08:41 GMT, Mandy Chung wrote:
>> Dan Smith has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix accidentally commented-out parts of test
>
> src/java.base/share/classes/java/lang/invoke/LambdaMetafactory.java line 45
On Thu, 3 Jun 2021 20:40:23 GMT, Dan Smith wrote:
>> Standardizes and better specifies the errors thrown by LambdaMetafactory,
>> including for inputs that would not be generated by javac.
>>
>> Does some renaming of core parameters/fields to better reflect their purpose.
>>
>> In the implemen
On Thu, 3 Jun 2021 20:40:23 GMT, Dan Smith wrote:
>> Standardizes and better specifies the errors thrown by LambdaMetafactory,
>> including for inputs that would not be generated by javac.
>>
>> Does some renaming of core parameters/fields to better reflect their purpose.
>>
>> In the implemen
On Thu, 3 Jun 2021 20:40:23 GMT, Dan Smith wrote:
>> Standardizes and better specifies the errors thrown by LambdaMetafactory,
>> including for inputs that would not be generated by javac.
>>
>> Does some renaming of core parameters/fields to better reflect their purpose.
>>
>> In the implemen
Yes, the CSR should be re-reviewed before the change goes in.
I've changed the CSR status to indicate it needs another review.
-Joe
On 6/3/2021 4:07 PM, Mandy Chung wrote:
On Thu, 3 Jun 2021 20:40:23 GMT, Dan Smith wrote:
Standardizes and better specifies the errors thrown by LambdaMetafac
On Thu, 3 Jun 2021 20:40:23 GMT, Dan Smith wrote:
>> Standardizes and better specifies the errors thrown by LambdaMetafactory,
>> including for inputs that would not be generated by javac.
>>
>> Does some renaming of core parameters/fields to better reflect their purpose.
>>
>> In the implemen
On Thu, 3 Jun 2021 20:40:23 GMT, Dan Smith wrote:
>> Standardizes and better specifies the errors thrown by LambdaMetafactory,
>> including for inputs that would not be generated by javac.
>>
>> Does some renaming of core parameters/fields to better reflect their purpose.
>>
>> In the implemen
> Standardizes and better specifies the errors thrown by LambdaMetafactory,
> including for inputs that would not be generated by javac.
>
> Does some renaming of core parameters/fields to better reflect their purpose.
>
> In the implementation, stops using ACC_BRIDGE for any methods, which is n
On Thu, 3 Jun 2021 20:03:53 GMT, Dan Smith wrote:
> Standardizes and better specifies the errors thrown by LambdaMetafactory,
> including for inputs that would not be generated by javac.
>
> Does some renaming of core parameters/fields to better reflect their purpose.
>
> In the implementation
- Mail original -
> De: "daniel smith"
> À: "Brian Goetz"
> Cc: "core-libs-dev"
> Envoyé: Samedi 23 Mars 2019 16:13:29
> Objet: Re: RFR: 8174222: LambdaMetafactory: validate inputs and improve
> documentation
>> On Mar 21, 2
> On Mar 21, 2019, at 8:58 AM, Brian Goetz wrote:
>
> +1 from me.
>
>
>> http://cr.openjdk.java.net/~dlsmith/8174222/webrev.00/
>>
>>
>
> AbstractValidatingLMF
> -
>
> I see you renamed most of the fields and params. Most of these are
> improvements, but it may be wort
+1 from me.
http://cr.openjdk.java.net/~dlsmith/8174222/webrev.00/
AbstractValidatingLMF
-
I see you renamed most of the fields and params. Most of these are
improvements, but it may be worth being more explicit in ambiguous
cases. For example, there are two method
> On Mar 20, 2019, at 11:22 PM, Mandy Chung wrote:
>
> On 3/20/19 9:03 PM, Dan Smith wrote:
>> http://cr.openjdk.java.net/~dlsmith/8174222/webrev.00/
>
> AbstractValidatingLambdaMetafactory.java
> +throw new LambdaConversionException("implementation is not
> direct or cannot be crac
On 3/20/19 9:03 PM, Dan Smith wrote:
http://cr.openjdk.java.net/~dlsmith/8174222/webrev.00/
AbstractValidatingLambdaMetafactory.java
+ throw new LambdaConversionException("implementation is not direct or
cannot be cracked"); It may help to print implementation method handle:
throw new Lam
23 matches
Mail list logo
