Re: RFR: 8195649: reorganize tests for java.util.Optional

2018-03-30 Thread Stuart Marks
Thanks. Regarding groups="unit" I wasn't entirely sure what to do about it. My first thought was that it's disused and to remove it, but then I looked and found that a bunch of other tests also declare themselves in the "unit" group: test/jdk/java/io/BufferedReader/Lines.java test/jdk/java/la

Re: RFR: 8195649: reorganize tests for java.util.Optional

2018-03-30 Thread Paul Sandoz
Very nice +1. You can probably remove the "groups = “unit”" from the @Test declarations. Paul. > On Mar 29, 2018, at 6:12 PM, Stuart Marks wrote: > > Hi all, > > Please review this changeset, which reorganizes (basically rewrites) the > tests for Optional and Optional{Double,Int,Long}. The