Re: RFR: 8222334: java -Xss0 triggers StackOverflowError

2019-04-16 Thread David Holmes
Subject: Re: RFR: 8222334: java -Xss0 triggers StackOverflowError Hi Patrick, On 16/04/2019 7:42 pm, Patrick Zhang OS wrote: Hi David, Please see my updates, the two '0' size test cases. I have run them with jtreg on jdk13 + linux + x86/aarch64 systems respectively, all pa

RE: RFR: 8222334: java -Xss0 triggers StackOverflowError

2019-04-16 Thread Patrick Zhang OS
Done. http://cr.openjdk.java.net/~qpzhang/8222334/webrev.05 Regards Patrick -Original Message- From: David Holmes Sent: Tuesday, April 16, 2019 6:34 PM To: Patrick Zhang OS Cc: core-libs-dev Subject: Re: RFR: 8222334: java -Xss0 triggers StackOverflowError Hi Patrick, On 16/04

Re: RFR: 8222334: java -Xss0 triggers StackOverflowError

2019-04-16 Thread David Holmes
Cc: core-libs-dev Subject: RE: RFR: 8222334: java -Xss0 triggers StackOverflowError Sure I will add this, and fix the intention mentioned by Alan. Regards Patrick -Original Message- From: David Holmes Sent: Tuesday, April 16, 2019 4:17 PM To: Patrick Zhang OS Cc: Alan Bateman ; cor

RE: RFR: 8222334: java -Xss0 triggers StackOverflowError

2019-04-16 Thread Patrick Zhang OS
f Patrick Zhang OS Sent: Tuesday, April 16, 2019 4:23 PM To: David Holmes Cc: core-libs-dev Subject: RE: RFR: 8222334: java -Xss0 triggers StackOverflowError Sure I will add this, and fix the intention mentioned by Alan. Regards Patrick -Original Message- From: David Holmes Sent: Tues

RE: RFR: 8222334: java -Xss0 triggers StackOverflowError

2019-04-16 Thread Patrick Zhang OS
Sure I will add this, and fix the intention mentioned by Alan. Regards Patrick -Original Message- From: David Holmes Sent: Tuesday, April 16, 2019 4:17 PM To: Patrick Zhang OS Cc: Alan Bateman ; core-libs-dev Subject: Re: RFR: 8222334: java -Xss0 triggers StackOverflowError Patrick

Re: RFR: 8222334: java -Xss0 triggers StackOverflowError

2019-04-16 Thread David Holmes
Patrick, Sorry should have picked up on this earlier. Can you please update the following two tests to add a test for '0' as appropriate: ./jdk/tools/launcher/TooSmallStackSize.java ./hotspot/jtreg/runtime/Thread/TooSmallStackSize.java Thanks, David On 16/04/2019 5:47 pm, David Holmes wrote:

Re: RFR: 8222334: java -Xss0 triggers StackOverflowError

2019-04-16 Thread David Holmes
On 16/04/2019 5:40 pm, Alan Bateman wrote: On 15/04/2019 08:48, David Holmes wrote: On 15/04/2019 5:34 pm, Patrick Zhang OS wrote: Removed it. http://cr.openjdk.java.net/~qpzhang/8222334/webrev.03/jdk.changeset By the way, could you please sponsor to push it once approved? thanks in advance.

Re: RFR: 8222334: java -Xss0 triggers StackOverflowError

2019-04-16 Thread Alan Bateman
On 15/04/2019 08:48, David Holmes wrote: On 15/04/2019 5:34 pm, Patrick Zhang OS wrote: Removed it. http://cr.openjdk.java.net/~qpzhang/8222334/webrev.03/jdk.changeset By the way, could you please sponsor to push it once approved? thanks in advance. Sure - if the core-libs person who also r

Re: RFR: 8222334: java -Xss0 triggers StackOverflowError

2019-04-15 Thread David Holmes
hint ;-) ) Cheers, David Regards Patrick -Original Message- From: David Holmes Sent: Monday, April 15, 2019 2:33 PM To: Patrick Zhang OS ; core-libs-dev Subject: Re: RFR: 8222334: java -Xss0 triggers StackOverflowError Hi Patrick, On 15/04/2019 3:42 pm, Patrick Zhang OS wrote: Hi

RE: RFR: 8222334: java -Xss0 triggers StackOverflowError

2019-04-15 Thread Patrick Zhang OS
-libs-dev Subject: Re: RFR: 8222334: java -Xss0 triggers StackOverflowError Hi Patrick, On 15/04/2019 3:42 pm, Patrick Zhang OS wrote: > Hi David, > > Many thanks, I integrated your updates into the new patch. Thanks. My only further comment is to not have: 947 * See JDK-82

Re: RFR: 8222334: java -Xss0 triggers StackOverflowError

2019-04-14 Thread David Holmes
e- From: David Holmes Sent: Monday, April 15, 2019 6:55 AM To: Patrick Zhang OS ; core-libs-dev Subject: Re: RFR: 8222334: java -Xss0 triggers StackOverflowError Hi Patrick, Please see: http://cr.openjdk.java.net/~dholmes/8222334/webrev/ for my suggested updates to the commentary. Note th

RE: RFR: 8222334: java -Xss0 triggers StackOverflowError

2019-04-14 Thread Patrick Zhang OS
rds Patrick -Original Message- From: David Holmes Sent: Monday, April 15, 2019 6:55 AM To: Patrick Zhang OS ; core-libs-dev Subject: Re: RFR: 8222334: java -Xss0 triggers StackOverflowError Hi Patrick, Please see: http://cr.openjdk.java.net/~dholmes/8222334/webrev/ for my suggested updat

Re: RFR: 8222334: java -Xss0 triggers StackOverflowError

2019-04-14 Thread David Holmes
day, April 12, 2019 3:43 PM To: Patrick Zhang OS ; jdk-...@openjdk.java.net Cc: jdk-updates-...@openjdk.java.net Subject: Re: RFR: 8222334: java -Xss0 triggers StackOverflowError Hi Patrick, Please takes this to core-libs-dev for review. Thanks, David On 12/04/2019 5:24 pm, Patrick Zhang OS wrot

Re: RFR: 8222334: java -Xss0 triggers StackOverflowError

2019-04-12 Thread David Holmes
review, thanks. Dropped and bcc'ed jdk-dev and jdk-updates-dev. Regards Patrick -Original Message- From: David Holmes Sent: Friday, April 12, 2019 3:43 PM To: Patrick Zhang OS ; jdk-...@openjdk.java.net Cc: jdk-updates-...@openjdk.java.net Subject: Re: RFR: 8222334: java -Xss0 tri

RE: RFR: 8222334: java -Xss0 triggers StackOverflowError

2019-04-12 Thread Patrick Zhang OS
t: Re: RFR: 8222334: java -Xss0 triggers StackOverflowError Hi Patrick, Please takes this to core-libs-dev for review. Thanks, David On 12/04/2019 5:24 pm, Patrick Zhang OS wrote: > Hi, > > Please review this patch. > > The problem is that the launcher does a check on the input -